Adding tests not settled detection support in tests #314
Conversation
| @@ -228,6 +232,28 @@ export function setupEmberOnerrorValidation() { | |||
| }); | |||
| } | |||
|
|
|||
| export function setupAsyncTimerLeakDetection() { | |||
| QUnit.testDone(({ module, name }) => { | |||
There was a problem hiding this comment.
making these callbacks separate (but private) exported functions will allow you to invoke them manually from within a single test and assert that the expected error is thrown....
There was a problem hiding this comment.
Sounds good. That will address my nagging guilt at the thought of pushing code with no tests!
There was a problem hiding this comment.
lol, its the guilt that drives me...
There was a problem hiding this comment.
Split things up. Added tests.
scalvert
changed the title
| } from '@ember/test-helpers'; | ||
| import { detectPendingTimers, reportPendingTimers } from './async-timer-leak-detection'; | ||
|
|
||
| const TESTS_WITH_LEAKY_ASYNC = []; |
There was a problem hiding this comment.
we should move this into the util file, no need to track it here and pass it around
There was a problem hiding this comment.
Good point. Not sure why I didn't see this....
| @@ -228,6 +233,18 @@ export function setupEmberOnerrorValidation() { | |||
| }); | |||
| } | |||
|
|
|||
| export function setupAsyncTimerLeakDetection() { | |||
| QUnit.testDone(({ module, name }) => { | |||
There was a problem hiding this comment.
Can we make this whole function the thing that is extracted? So that the resulting code would be:
QUnit.testDone(importedThingGoesHere);
QUnit.done(otherImportedThingGoesHere);
scalvert
changed the title
|
So I know that settled doesn't necessarily immediately scream what it does, it is consistent from That said, if I were to change it, I'd probably opt for:
That helps convey that we're setting up async leak detection for tests. What do you think? |
|
@rwjblue and I arrived at |
|
@rwjblue any more changes required here? |
This PR adds support for detecting if a test is not settled in tests. It tests for the settledness of timers via
isSettledinember-test-helpers.A test is considered settled if it: