Fix error message for test isolation validation #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idation to avoid outputting undefined
rwjblue
approved these changes
Jul 30, 2019
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactor that moved the test isolation validation primitives to
@ember/test-helpers, themessageproperty on theDebugInfoclass was removed. We did this as that output is static, and is better moved as a static string inside test-isolation-validation.js. Unfortunately, I forgot to inline the contents of themessageproperty into the right location, and it continued to try to access a now non-existent property. This resulted in the output addingundefinedat the end of the test isolation validation output. This PR fixes that.