Skip to content

Commit

Permalink
Avoid using container.register.
Browse files Browse the repository at this point in the history
  • Loading branch information
rwjblue committed Jul 21, 2015
1 parent 08b2e79 commit bc63036
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
6 changes: 3 additions & 3 deletions lib/ember-test-helpers/test-module-for-component.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ export default TestModule.extend({
setupComponentUnitTest: function() {
var _this = this;
var resolver = getResolver();
var container = this.container;
var context = this.context;

var layoutName = 'template:components/' + this.componentName;

var layout = resolver.resolve(layoutName);

var thingToRegisterWith = this.registry || this.container;
if (layout) {
container.register(layoutName, layout);
container.injection(this.subjectName, 'layout', layoutName);
thingToRegisterWith.register(layoutName, layout);
thingToRegisterWith.injection(this.subjectName, 'layout', layoutName);
}

context.dispatcher = Ember.EventDispatcher.create();
Expand Down
4 changes: 3 additions & 1 deletion lib/ember-test-helpers/test-module-for-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ export default TestModule.extend({
var adapterFactory = container.lookupFactory('adapter:application');
if (!adapterFactory) {
adapterFactory = DS.JSONAPIAdapter || DS.FixtureAdapter;
container.register('adapter:application', adapterFactory);

var thingToRegisterWith = this.registry || this.container;
thingToRegisterWith.register('adapter:application', adapterFactory);
}

callbacks.store = function(){
Expand Down
3 changes: 2 additions & 1 deletion tests/test-module-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ moduleFor('component:x-foo', 'component:x-foo -- setup context', {
name: 'Max'
});

this.container.register('service:blah', Ember.Object.extend({
var thingToRegisterWith = this.registry || this.container;
thingToRegisterWith.register('service:blah', Ember.Object.extend({
purpose: 'blabering'
}));
}
Expand Down

0 comments on commit bc63036

Please sign in to comment.