Deprecation Warning thrown Even when needs:[] is passed

[blimmer]

I first noticed this and reported it upstream with ember-mocha (emberjs/ember-mocha#129), but I think it's actually an issue with a change made to test-module-for-component.

This issue doesn't show with current ember-qunit and ember-test-helpers

├─┬ ember-cli-qunit@2.2.5
│ └─┬ ember-qunit@0.4.22
│   └── ember-test-helpers@0.5.34

but between 0.5.34 and 0.6.x, a call to super was added before checking the options passed:

ember-test-helpers/lib/ember-test-helpers/test-module-for-component.js

Line 29 in d5c50d0

super('component:' + componentName, description, callbacks);

This call mutates the options hash and deletes the needs key:

ember-test-helpers/lib/ember-test-helpers/test-module.js

Line 50 in d5c50d0

delete this.callbacks.needs;

Which then causes the deprecation to fire:

ember-test-helpers/lib/ember-test-helpers/test-module-for-component.js

Lines 38 to 45 in d5c50d0

	Ember.deprecate(
	"the component:" + componentName + " test module is implicitly running in unit test mode, " +
	"which will change to integration test mode by default in an upcoming version of " +
	"ember-test-helpers. Add `unit: true` or a `needs:[]` list to explicitly opt in to unit " +
	"test mode.",
	false,
	{ id: 'ember-test-helpers.test-module-for-component.test-type', until: '0.6.0' }
	);

I have a proof of concept exposing this error here:

https://github.com/blimmer/ember-cli-example-app-for-github/compare/ember-mocha/issue-129

I'm not sure what the right fix is, maybe moving the call to super below the checks?

[rwjblue]

Thanks for the detailed write up, will try to poke at this tomorrow...

[Turbo87]

@blimmer the issue with calling super() later is that you have no access to this before the super() call happened and that's also the reason why I had to move the call.