Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests in v0.7.0-beta.8 #231

Closed
Turbo87 opened this issue Oct 21, 2017 · 2 comments
Closed

Broken tests in v0.7.0-beta.8 #231

Turbo87 opened this issue Oct 21, 2017 · 2 comments
Labels

Comments

@Turbo87
Copy link
Member

Turbo87 commented Oct 21, 2017

It looks like v0.7.0-beta.8 (with #229) broke some of our existing old API tests.

Most failures seem to look like this:

        actual: >
            Element .edit-order-email-dialog does not exist
        expected: >
            Element .edit-order-email-dialog exists
@Turbo87 Turbo87 added the bug label Oct 21, 2017
@rwjblue
Copy link
Member

rwjblue commented Oct 21, 2017

What kind of test (moduleForComponent, etc)? Are all failing or just some? If you inspect the DOM at the time of the failed assertion does it contain the correct things (but just in a nested element or something)?

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 21, 2017

This was apparently caused by qunit-dom caching the reference to the #ember-testing element, but #229 changed the behavior to recreate a new element for each test. This issue was resolved in mainmatter/qunit-dom#33 and released as qunit-dom@0.3.3.

@Turbo87 Turbo87 closed this as completed Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants