Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to @ember/test-helpers #240

Closed
Turbo87 opened this issue Nov 8, 2017 · 1 comment
Closed

Rename to @ember/test-helpers #240

Turbo87 opened this issue Nov 8, 2017 · 1 comment

Comments

@Turbo87
Copy link
Member

Turbo87 commented Nov 8, 2017

With the introduction of RFC 176 Ember moved towards import paths prefixed with @ember/ which ultimately should use the @ember scope on npm. This gives us a better indicator of a project being official or a community-project. Since ember-test-helpers is an official project it might make sense to move it to @ember/test-helpers too.

emberjs/rfcs#268 is introducing a public API for this package for the first time so we should probably decide this until the RFC lands.

/cc @rwjblue

@rwjblue
Copy link
Member

rwjblue commented Nov 8, 2017

👍 I am in favor of this. Since this package is generally provided as a transitive dependency, the only real issue would be to ensure that the current ember-test-helpers imports continue to work after the transition (which should be pretty easy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants