Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isolated-container depends on private view #30

Closed
habdelra opened this issue Mar 25, 2015 · 3 comments
Closed

isolated-container depends on private view #30

habdelra opened this issue Mar 25, 2015 · 3 comments

Comments

@habdelra
Copy link

The isolated-container depends on a private view: Ember._MetamorphView

https://github.com/switchfly/ember-test-helpers/blob/master/lib/ember-test-helpers/isolated-container.js#L64

This private view is no longer available as of this PR emberjs/ember.js#10670
@rwjblue
Copy link
Member

rwjblue commented Mar 25, 2015

👍 - looking into it now

@rwjblue rwjblue mentioned this issue Mar 26, 2015
Merged
@rwjblue
Copy link
Member

rwjblue commented Mar 26, 2015

emberjs/ember.js#10729 reverts the change in Ember. We will still need to come up with a path forward so that these can be removed in 2.0, but I'd prefer to do that thinking with a green test suite.

@rwjblue
Copy link
Member

rwjblue commented Mar 26, 2015

Fixed upstream for now.

@rwjblue rwjblue closed this as completed Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @habdelra