Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleForComponent accepts 3 or 1 argument, should also accept 2 #52

Closed
dandehavilland opened this issue May 18, 2015 · 7 comments · Fixed by #53
Closed

moduleForComponent accepts 3 or 1 argument, should also accept 2 #52

dandehavilland opened this issue May 18, 2015 · 7 comments · Fixed by #53

Comments

@dandehavilland
Copy link

Works: moduleForComponent('pie-chart');
Works: moduleForComponent('pie-chart', 'PieChartComponent', {});

Errors: moduleForComponent('pie-chart', 'PieChartComponent');

'undefined' is not an object (evaluating 'callbacks.needs')

/cc @sbl

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

This has been resolved and released in #48 and released as ember-test-helpers@0.4.5. It is also included in ember-qunit@0.3.3.

@rwjblue rwjblue closed this as completed May 18, 2015
@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

Whoops, wait, let me confirm that...

@rwjblue rwjblue reopened this May 18, 2015
@dandehavilland
Copy link
Author

I'm running ember-cli@0.2.5, that introduced the failures for me (upgraded from 0.2.3)

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

The ember-cli version is not directly related to the version of this library (though it does ship with a default). What version of ember-qunit are you using?

@dandehavilland
Copy link
Author

"ember-qunit": "0.3.3"

@dandehavilland
Copy link
Author

Thanks for the quick response!

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

Released as v0.3.4 of ember-qunit (and 0.4.6 of ember-test-helpers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants