Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with new Container/Registry Implementation #7

Closed
rwjblue opened this issue Dec 31, 2014 · 7 comments
Closed

Working with new Container/Registry Implementation #7

rwjblue opened this issue Dec 31, 2014 · 7 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Dec 31, 2014

@dgeb - You are the most knowledgeable on these changes in Ember itself. What changes are needed here to accommodate them?

@rwjblue
Copy link
Member Author

rwjblue commented Jan 8, 2015

@dgeb - We really need to make a game plan for this, as 1.11.0-beta.1 will be shipping in a couple weeks....

@dgeb
Copy link
Member

dgeb commented Jan 8, 2015

@rwjblue ok, so the game plan we discussed in IRC is:

  1. Fix up isolatedContainer to avoid deprecations for now
    1. Build a registry with Application.buildRegistry() - eliminating need for custom registrations
    2. Create a container with registry.container()
    3. Override container.register to call container._registry.register without deprecations. Consider overriding other registry calls without deprecations as well.
  2. If supported, use ApplicationInstance instead of isolatedContainer, in ember-test-helpers

@rwjblue
Copy link
Member Author

rwjblue commented Jan 15, 2015

Downstream issue in ember-qunit: https://github.com/rwjblue/ember-qunit/issues/118

@dgeb
Copy link
Member

dgeb commented Feb 10, 2015

The deprecation warnings are now showing up in 1.11 beta, so we need to tackle this very soon.

@rwjblue
Copy link
Member Author

rwjblue commented Feb 10, 2015

Yes, agreed.

@dgeb
Copy link
Member

dgeb commented Feb 10, 2015

See #15 for a quick fix to silence the deprecation warnings. I avoided the steps above (for now) because buildRegistry has gotten more complicated, and now involves configuration of a resolver. I think all that can wait until we straighten out ApplicationInstance and expose that for testing instead of isolatedContainer.

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

It seems to me that this issue is no longer relevant 🤔

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants