Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back {{#in-element}} test in ember-classic #1101

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Bring back {{#in-element}} test in ember-classic #1101

merged 1 commit into from
Aug 9, 2021

Commits on Aug 9, 2021

  1. Bring back {{#in-element}} test in ember-classic 

    After reviewing further we determined that the issue that was causing
the failure with the `{{#in-element` setup is that `insertBefore` is
required in order to force "append" mode. Without `insertBefore` the
rendering engine will actually **clear** the contents of the target
element (which is waht causes the errors we were seeing).
    @rwjblue
    rwjblue committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    d1cc08f View commit details
    Browse the repository at this point in the history