feat: add 'before-fire-event' hook to helpers with side-effects
#1183
Conversation
A `'before-fire-event'` hook is added to any helper that scrolls or changes values in the DOM. These hooks allow better control of the DOM in cases where code needs to be executed _after_ a helper affects the DOM as well as _before_ an event is fired.
|
|
||
| return settled(); | ||
| }) | ||
| .then(() => runHooks('fillIn', 'before-fire-event', target, text)) |
There was a problem hiding this comment.
I was thinking that you would actually add this to fireEvent itself, that way you only haev to change one file (not all of hte dom helpers).
Is there any reason that wouldn't work?
There was a problem hiding this comment.
Yes, I think it'll work. Giving it a shot this morning 👍
There was a problem hiding this comment.
So I'm now deep into this thing, and thought I should check in about my progress and confirm that the direction I'm heading is kosher.
Specifically, given the hooks system uses Promises, I've been forced to "Promisify" any function where fireEvent is called. Given the library forbids the use of async/await, in places, the changes are fairly substantial and it's not easy to keep things readable. I've managed to keep things passable.
My assumption about async/await is that we forbid it for backwards compatibility with older apps. Is that correct?
Anyway, I'm about 60–80% of the way done now.
|
Closing this PR in favour of #1185 |
A
'before-fire-event'hook is added to any helper that involves side-effects — i.e. scrolls or changes values in the DOM prior to firing achangeevent. These hooks allow better control of the DOM in cases where code needs to be executed after a helper affects the DOM as well as before an event is fired.This PR follows from my conversation in #1182, and should serve to resolve an issue I have following @rwjblue's suggestion therein.