Use ember preview types #1272
Use ember preview types #1272
Conversation
gitKrystan
force-pushed
the
preview-types
branch
2 times, most recently
from
a895a7e
to
3879e2f
Compare
| @@ -58,9 +58,11 @@ const Owner = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixin, { | |||
| * @see {@link https://github.com/emberjs/ember.js/blob/v4.5.0-alpha.5/packages/%40ember/engine/instance.ts#L152-L167} | |||
| */ | |||
| unregister(fullName: string) { | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
These types aren't public and there is a bunch of EmberObject and as any in this file, so I figured leaving @ts-expect-error was OK...
There was a problem hiding this comment.
That's the best move, yep. We can flag it up for figuring out a non-private-API way of tackling in the future!
gitKrystan
force-pushed
the
preview-types
branch
2 times, most recently
from
b15da29
to
500e7b7
Compare
| "@types/ember__runloop": "~4.0.1", | ||
| "@types/ember__service": "~4.0.0", | ||
| "@types/ember__test": "~4.0.0", | ||
| "@types/jquery": "^3.5.14", |
There was a problem hiding this comment.
This is needed because @types/ember-testing-helpers was removed.
| @@ -9,5 +9,5 @@ | |||
| "*": ["./types/*"] | |||
| } | |||
| }, | |||
| "include": ["./addon-test-support/**/*.ts", "tests/**/*.ts"] | |||
| "include": ["addon-test-support/**/*.ts", "tests/**/*.ts", "types/**/*.ts"] | |||
There was a problem hiding this comment.
This was necessary for the types to see types/dummy/index.d.ts
gitKrystan
force-pushed
the
preview-types
branch
from
500e7b7
to
841984e
Compare
| @@ -13,5 +13,6 @@ | |||
| "types/*" | |||
| ] | |||
| } | |||
| } | |||
| }, | |||
| "include": ["api.ts", "../types/**/*"] | |||
There was a problem hiding this comment.
This was necessary for the types to see types/dummy/index.d.ts
| @@ -58,9 +58,11 @@ const Owner = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixin, { | |||
| * @see {@link https://github.com/emberjs/ember.js/blob/v4.5.0-alpha.5/packages/%40ember/engine/instance.ts#L152-L167} | |||
| */ | |||
| unregister(fullName: string) { | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
That's the best move, yep. We can flag it up for figuring out a non-private-API way of tackling in the future!
Depends on #1271
Should unblock fixing emberjs/ember.js#20254