Upgrade ember v3.27.0...v4.9.2 (in development) #1271

gitKrystan · 2022-11-30T18:05:04Z

This will give us access to the preview types, which will help with emberjs/ember.js#20254

Read carefully because I guessed on a lot of things. 🤠

gitKrystan · 2022-11-30T18:06:45Z

README.md

+- Ember.js v3.28 or above
+- Ember CLI v3.28 or above
+- Node.js v14 or above


These changes came from the blueprints. The peerDependencies field currently says "ember-source": ">=3.8.0" so I imagine that would need to be updated as well.

Hmmmmmm. It'd be better (I'm not sure if it's possible, but given the APIs in question I would expect it is?) to leave these untouched while moving to Ember 4.8/4.9, so that we don't have to cut a breaking change for folks to get these benefits. We do need to make a breaking change, but we'd prefer to get a last feature release out, then make the breaking change which drops support for older versions.

Also, @rwjblue may have thoughts on the version support policy; this library in particular has intentionally supported a very wide range of Ember versions, and we likely want to continue to do so… but it's possible that 3.28 is good enough.

Either way, if it's possible, let's back out these changes (and the corresponding changes to the CI matrix above) to support all of the existing supported versions unless something forces us to drop them.

Update: It turns out ember-source 4.9 drops support for node 12 & 14, so we'll drop support here as well.

gitKrystan · 2022-11-30T18:06:59Z

CONTRIBUTING.md

@@ -3,7 +3,7 @@
 ## Installation

 * `git clone <repository-url>`
-* `cd @ember/test-helpers`
+* `cd ember-test-helpers`


This more closely matches what I actually had to do when installing.

gitKrystan · 2022-11-30T18:07:41Z

.github/workflows/ci-build.yml

@@ -18,8 +18,6 @@ jobs:
    steps:
      - uses: actions/checkout@v2
      - uses: volta-cli/action@v1
-        with:
-          node-version: 10.x


Volta will use node 18. If we want to use an older version of node for some of the steps I can add these back w/ 14+.

We definitely need to test against Node 14, and indeed our whole supported range of Node versions, so I'm surprised we don't have a test matrix set up for that. I generally have a mild preference for running against the lowest supported version in development, simply because that's the way someone developing is least likely.

We can make the changes in a separate PR to keep this train moving, but we should:

pin Node 14 with Volta for development

add a matrix for Node version support, that explicitly handles 16 and 18 (since 14 will be covered "automatically")

Removing them all here and using Volta seems good, though!

gitKrystan · 2022-11-30T18:08:50Z

config/ember-try.js

-      {
-        name: 'ember-default-with-jquery',
-        env: {
-          EMBER_OPTIONAL_FEATURES: JSON.stringify({
-            'jquery-integration': true,
-          }),
-        },
-        npm: {
-          devDependencies: {
-            '@ember/jquery': '^0.6.0',
-            'ember-fetch': null,
-          },
-        },
-      },


The changes in this file are straight from the blueprints. IDK what is right here.

We might still want something for jQuery this bc there does seem to be jQuery handling in the code. It has notes in it that it can be removed w/ Ember 4+ though, but I figured I should leave it since 3.28 will still be supported?

gitKrystan · 2022-11-30T18:10:34Z

ember-cli-build.js

+      skipBabel: [
+        {
+          package: 'qunit',
+        },
+      ],


This is from the blueprints. IDK if it's right or not.

Seems likely to be! 😁

gitKrystan · 2022-11-30T18:11:49Z

package.json

@@ -44,76 +44,76 @@
  },
  "dependencies": {
    "@ember/test-waiters": "^3.0.0",
-    "@embroider/macros": "^1.6.0",
-    "@embroider/util": "^1.6.0",
+    "@embroider/macros": "^1.10.0",


Build broke w/o embroider upgrades

gitKrystan · 2022-11-30T18:12:05Z

package.json

  },
  "devDependencies": {
    "@babel/cli": "^7.18.9",
+    "@babel/core": "^7.20.5",


Required by peer-deps of several libraries

chriskrycho

This is great! I have a pair of suggested tweaks, but great forward progress!

chriskrycho · 2022-11-30T21:36:11Z

.ember-cli

+  /**
+  Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
+  rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
+  */
+  "isTypeScriptProject": true


chriskrycho · 2022-11-30T21:40:10Z

.github/workflows/ci-build.yml

@@ -18,8 +18,6 @@ jobs:
    steps:
      - uses: actions/checkout@v2
      - uses: volta-cli/action@v1
-        with:
-          node-version: 10.x


We definitely need to test against Node 14, and indeed our whole supported range of Node versions, so I'm surprised we don't have a test matrix set up for that. I generally have a mild preference for running against the lowest supported version in development, simply because that's the way someone developing is least likely.

We can make the changes in a separate PR to keep this train moving, but we should:

pin Node 14 with Volta for development

add a matrix for Node version support, that explicitly handles 16 and 18 (since 14 will be covered "automatically")

Removing them all here and using Volta seems good, though!

chriskrycho · 2022-11-30T21:58:46Z

README.md

+- Ember.js v3.28 or above
+- Ember CLI v3.28 or above
+- Node.js v14 or above


Hmmmmmm. It'd be better (I'm not sure if it's possible, but given the APIs in question I would expect it is?) to leave these untouched while moving to Ember 4.8/4.9, so that we don't have to cut a breaking change for folks to get these benefits. We do need to make a breaking change, but we'd prefer to get a last feature release out, then make the breaking change which drops support for older versions.

Also, @rwjblue may have thoughts on the version support policy; this library in particular has intentionally supported a very wide range of Ember versions, and we likely want to continue to do so… but it's possible that 3.28 is good enough.

Either way, if it's possible, let's back out these changes (and the corresponding changes to the CI matrix above) to support all of the existing supported versions unless something forces us to drop them.

config/ember-try.js

chriskrycho · 2022-11-30T21:59:27Z

ember-cli-build.js

+      skipBabel: [
+        {
+          package: 'qunit',
+        },
+      ],


Seems likely to be! 😁

chriskrycho · 2022-11-30T22:02:25Z

package.json

-    "ember-resolver": "^8.0.2",
-    "ember-source": "~3.28.4",
+    "ember-resolver": "^8.0.3",
+    "ember-source": "~4.9.0",


Heh, looks like we need to rename the PR to specify 4.9 instead of 4.8! 🎉

chriskrycho · 2022-11-30T22:04:36Z

package.json

    "release-it": "~14.11.6",
    "release-it-lerna-changelog": "^3.1.0",
    "rimraf": "^3.0.2",
    "typescript": "^4.7.4",
    "webpack": "^5.74.0"
  },
  "engines": {
-    "node": "10.* || 12.* || 14.* || 15.* || >= 16.*"
+    "node": "14.* || 16.* || >= 18"


Unless we have to change this, we should keep it separate. Reading this set of changes to package.json, I'm assuming the reason you ended up bumping it is because you bumped ember-cli as well as the others, which in turn requires it for more recent versions IIRC? If so, try reverting to the previous version of ember-cli, which should be forward compatible with these versions of ember-source etc., and that will allow us to make the move I described above in terms of versioning/release strategy.

I think it's coming from ember-source as well.

ember-source@4.9.0: The engine "node" is incompatible with this module. Expected version ">= 14.*". Got "12.22.4"

For posterity: I made the change, which landed in Ember 4.9, to drop support for older versions of Node in Ember itself… and had forgotten it when I made this comment.

What I think I’m going to do is cut a release of the current major version of @ember/test-helpers which does not include this particular update, but does ship types. That'll do what we intended to do months ago (though apparently no one has been depending on that, since we haven't gotten bug reports!). At that point I'll also update DefinitelyTyped to match.

Then this PR, and shipping native Ember types, can go into a new major version.

gitKrystan · 2022-12-01T00:30:49Z

UPDATE: Resolved the issue below. It was related to an issue in my dev environment. Phew.

There might be an issue somewhere. I am trying to use this version locally and getting:

WARNING in ./node_modules/@ember/test-helpers/index.js 3:0-262
export 'DeprecationFailure' (reexported as 'DeprecationFailure') was not found in './setup-context' (possible exports: ComponentRenderMap, SetUsage, default, getContext, getDeprecations, getDeprecationsDuringCallback, getWarnings, getWarningsDuringCallback, isTestContext, pauseTest, resumeTest, setContext, unsetContext)
 @ ./assets/test.js 143:13-65

WARNING in ./node_modules/@ember/test-helpers/index.js 3:0-262
export 'Warning' (reexported as 'Warning') was not found in './setup-context' (possible exports: ComponentRenderMap, SetUsage, default, getContext, getDeprecations, getDeprecationsDuringCallback, getWarnings, getWarningsDuringCallback, isTestContext, pauseTest, resumeTest, setContext, unsetContext)
 @ ./assets/test.js 143:13-65

WARNING in ./node_modules/@ember/test-helpers/index.js 3:0-262
export 'BaseContext' (reexported as 'BaseContext') was not found in './setup-context' (possible exports: ComponentRenderMap, SetUsage, default, getContext, getDeprecations, getDeprecationsDuringCallback, getWarnings, getWarningsDuringCallback, isTestContext, pauseTest, resumeTest, setContext, unsetContext)
 @ ./assets/test.js 143:13-65

WARNING in ./node_modules/@ember/test-helpers/index.js 3:0-262
export 'TestContext' (reexported as 'TestContext') was not found in './setup-context' (possible exports: ComponentRenderMap, SetUsage, default, getContext, getDeprecations, getDeprecationsDuringCallback, getWarnings, getWarningsDuringCallback, isTestContext, pauseTest, resumeTest, setContext, unsetContext)
 @ ./assets/test.js 143:13-65

WARNING in ./node_modules/@ember/test-helpers/index.js 12:0-76
export 'default' (reexported as 'DebugInfo') was not found in './-internal/debug-info' (possible exports: TestDebugInfo, backburnerDebugInfoAvailable, getDebugInfo)
 @ ./assets/test.js 143:13-65

WARNING in ./node_modules/@ember/test-helpers/index.js 14:0-75
export 'TestMetadata' (reexported as 'TestMetadata') was not found in './test-metadata' (possible exports: __TestMetadata, default)
 @ ./assets/test.js 143:13-65

Update: This might be a problem on master

chriskrycho · 2022-12-08T22:20:33Z

@gitKrystan I'm going to re-review the changes now, but we'll need to update the CI config in .github/workflows/ci-build.yml so that CI can pass given we're dropping everything before 3.28 LTS here.

chadhietala · 2022-12-12T00:30:16Z

Eh I tried to help here but it looks like it needs to be rebased.

gitKrystan · 2022-12-12T18:20:27Z

Rebased

gitKrystan · 2022-12-12T21:50:32Z

Looks like the embroider-safe ember try failure happens on master too, so I am assuming I didn't cause that.

.github/workflows/ci-build.yml

chriskrycho

Couple of tiny tweaks here, and then let's land it!

package.json

chriskrycho · 2022-12-13T18:15:33Z

package.json

    "release-it": "~14.11.6",
    "release-it-lerna-changelog": "^3.1.0",
    "rimraf": "^3.0.2",
    "typescript": "^4.7.4",
    "webpack": "^5.74.0"
  },
  "engines": {
-    "node": "10.* || 12.* || 14.* || 15.* || >= 16.*"
+    "node": "14.* || 16.* || >= 18"


For posterity: I made the change, which landed in Ember 4.9, to drop support for older versions of Node in Ember itself… and had forgotten it when I made this comment.

What I think I’m going to do is cut a release of the current major version of @ember/test-helpers which does not include this particular update, but does ship types. That'll do what we intended to do months ago (though apparently no one has been depending on that, since we haven't gotten bug reports!). At that point I'll also update DefinitelyTyped to match.

Then this PR, and shipping native Ember types, can go into a new major version.

chriskrycho · 2022-12-13T18:16:11Z

tests/dummy/config/ember-try.js

          },
        },
      },
      {
-        name: 'ember-lts-3.28',
+        name: 'ember-lts-4.4',


As noted above, as of this week, we also need an ember-lts-4.8 scenario.

Remove old versions of ember

.github/workflows/ci-build.yml

gitKrystan · 2022-12-13T23:06:04Z

@chriskrycho Rebased

chriskrycho · 2022-12-13T23:33:43Z

Needs to test 4.8, not just 4.4 twice! 😄

chriskrycho

Let's do it! 🎉 🚀

The `concurrently` invocation was set to run all `ember-try` scenarios *every* time we run `yarn test` either locally or in CI, rather than only when we opt into doing so with `test:all`. Switch back to doing a single `ember test` invocation as the main `test` invocation instead.

We want this on at *some* point, but not as part of this PR.

gitKrystan commented Nov 30, 2022

View reviewed changes

gitKrystan mentioned this pull request Nov 30, 2022

Use ember preview types #1272

Merged

chriskrycho requested changes Nov 30, 2022

View reviewed changes

gitKrystan changed the title ~~Upgrade ember v3.27.0...v4.8.0 (in development)~~ Upgrade ember v3.27.0...v4.9.0 (in development) Nov 30, 2022

gitKrystan mentioned this pull request Dec 3, 2022

Spike on TS types emberjs/ember-qunit#992

Closed

chriskrycho added enhancement breaking labels Dec 8, 2022

gitKrystan force-pushed the ember-4.9 branch from 69ae2c9 to 27d4fe4 Compare December 12, 2022 18:20

gitKrystan changed the title ~~Upgrade ember v3.27.0...v4.9.0 (in development)~~ Upgrade ember v3.27.0...v4.9.1 (in development) Dec 12, 2022

gitKrystan changed the title ~~Upgrade ember v3.27.0...v4.9.1 (in development)~~ Upgrade ember v3.27.0...v4.9.2 (in development) Dec 13, 2022

chriskrycho reviewed Dec 13, 2022

View reviewed changes

.github/workflows/ci-build.yml Show resolved Hide resolved

chriskrycho requested changes Dec 13, 2022

View reviewed changes

gitKrystan force-pushed the ember-4.9 branch from 7e7d16a to 680ea54 Compare December 13, 2022 22:27

gitKrystan and others added 4 commits December 13, 2022 14:31

Upgrade ember v3.27.0...v4.9.0 (in development)

0ab9a81

Address PR feedback

23bde84

Fix CI

2e91013

Update ci-build.yml

ef00b48

Remove old versions of ember

chriskrycho reviewed Dec 13, 2022

View reviewed changes

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved

Upgrade ember to v4.9.1

5b97534

gitKrystan added 4 commits December 13, 2022 14:32

Update ci-build.yml

37ece8d

Upgrade ember to 4.9.2

679c83d

Test against 4.4-lts

8e9f376

Finish switch from npm-run-all to concurrently

c6f097d

gitKrystan force-pushed the ember-4.9 branch from 55fff90 to c6f097d Compare December 13, 2022 22:52

gitKrystan added 2 commits December 13, 2022 16:58

Actually test against 4.8 in CI

34e51ff

Merge branch 'master' into ember-4.9

1406f2f

chriskrycho approved these changes Dec 14, 2022

View reviewed changes

Add @types/ember-resolver

dea3d3a

chriskrycho approved these changes Dec 14, 2022

View reviewed changes

chriskrycho added 2 commits December 14, 2022 09:58

Turn back off embroider-optimized scenario

5cbfe03

We want this on at *some* point, but not as part of this PR.

chriskrycho merged commit 2c8ce6f into emberjs:master Dec 14, 2022

gitKrystan deleted the ember-4.9 branch December 14, 2022 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ember v3.27.0...v4.9.2 (in development) #1271

Upgrade ember v3.27.0...v4.9.2 (in development) #1271

gitKrystan commented Nov 30, 2022

gitKrystan Nov 30, 2022

chriskrycho Nov 30, 2022

gitKrystan Nov 30, 2022

gitKrystan Nov 30, 2022

gitKrystan Nov 30, 2022

chriskrycho Nov 30, 2022

gitKrystan Nov 30, 2022 •

edited

gitKrystan Nov 30, 2022

chriskrycho Nov 30, 2022

gitKrystan Nov 30, 2022

gitKrystan Nov 30, 2022

chriskrycho left a comment

chriskrycho Nov 30, 2022

chriskrycho Nov 30, 2022

chriskrycho Nov 30, 2022

chriskrycho Nov 30, 2022

chriskrycho Nov 30, 2022

chriskrycho Nov 30, 2022

gitKrystan Nov 30, 2022

chriskrycho Dec 13, 2022 •

edited

gitKrystan commented Dec 1, 2022 •

edited

chriskrycho commented Dec 8, 2022

chadhietala commented Dec 12, 2022

gitKrystan commented Dec 12, 2022

gitKrystan commented Dec 12, 2022

chriskrycho left a comment

chriskrycho Dec 13, 2022 •

edited

chriskrycho Dec 13, 2022

gitKrystan commented Dec 13, 2022

chriskrycho commented Dec 13, 2022

chriskrycho left a comment

Upgrade ember v3.27.0...v4.9.2 (in development) #1271

Upgrade ember v3.27.0...v4.9.2 (in development) #1271

Conversation

gitKrystan commented Nov 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitKrystan Nov 30, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chriskrycho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chriskrycho Dec 13, 2022 • edited

Choose a reason for hiding this comment

gitKrystan commented Dec 1, 2022 • edited

chriskrycho commented Dec 8, 2022

chadhietala commented Dec 12, 2022

gitKrystan commented Dec 12, 2022

gitKrystan commented Dec 12, 2022

chriskrycho left a comment

Choose a reason for hiding this comment

chriskrycho Dec 13, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitKrystan commented Dec 13, 2022

chriskrycho commented Dec 13, 2022

chriskrycho left a comment

Choose a reason for hiding this comment

gitKrystan Nov 30, 2022 •

edited

chriskrycho Dec 13, 2022 •

edited

gitKrystan commented Dec 1, 2022 •

edited

chriskrycho Dec 13, 2022 •

edited