Convert to single-workspace monorepo #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
This was referenced Mar 21, 2023
Closed
…mponent a type-guard function isComponent can determine ComponentLikeness
bertdeblock
reviewed
Mar 21, 2023
phndiaye
approved these changes
Mar 23, 2023
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a different approach for v2 conversion -- gonna try re-evaluating the validity of using yarn in v2 addon monorepos.
All steps done with https://github.com/NullVoxPopuli/ember-addon-migrator
Step 1: convert to monorepo (this PR)
Step 2: extract test app to separate workspace
Step 3: convert
./addonto v2 addon-> this step 3 will include the removal of all the build-time sillyness and legacy ember-test-helpers things, leaving only
@ember/test-helpers🎉