destroy the subject in teardown

[CodeOfficer]

I'm not sure what there is to test here so I didn't add any tests yet.

Currently the container is destroyed which takes care of destroying any dependencies brought in by needs but the subject is never properly town down. This makes sure that happens.

[rwjblue]

I'd like to see the following test near the end of https://github.com/switchfly/ember-test-helpers/blob/master/tests/test-module-test.js:

moduleFor('component:x-foo', 'component:x-foo -- created subjects are cleaned up', {
  beforeSetup: function() {
    setupRegistry();
  },

  afterTeardown: function() {
    var subject = this.cache.subject;

    ok(subject.isDestroyed);
  }
});

test("subject's created in a test are destroyed", function() {
  this.subject();
});

moduleFor('component:x-foo', 'component:x-foo -- uncreated subjects do not error', {
  beforeSetup: function() {
    setupRegistry();
  }
});

test("subject's created in a test are destroyed", function() {
  expect(0);
});

[rwjblue]

It is possible that subject does not have a destroy method so you will probably want to do something like:

Ember.run(function() {
  Ember.tryInvoke(subject, 'destroy');
});

[CodeOfficer]

^_^

[rwjblue]

❤️

[rwjblue]

I'm 👍, but I'll give @dgeb a chance to chime in...

[dgeb]

Looks great - thanks @CodeOfficer!

[rwjblue]

released in v0.3.4 of ember-test-helpers and v0.2.10 of ember-qunit.