Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUnit module example #186

Merged
merged 1 commit into from Nov 29, 2016
Merged

Update QUnit module example #186

merged 1 commit into from Nov 29, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2016

It was still written with the deprecated setup and teardown callbacks.

It was still written with the deprecated `setup` and `teardown` callbacks.
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, but I'd like someone else to approve this too before we merge it

@rwjblue rwjblue merged commit 4906756 into emberjs:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants