Fix order dependence in tests. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No clue why this isn't the default in QUnit, but reordering + testing a specific seed (to track down order dependent test issues) is _really_ hard. This change ensures that when running with a specific seed tests are **always** ran in the seed determined order (therefore making back to back "reloads" consistently fail).
Having this do a `strictEqual` previously meant that the entire test context was dumped upon failure, which was less than helpful.
Throwing during a `QUnit.testDone` callback causes the entire test suite to abort (and does not actually fail the test in question anyways). This changes things around so that we track these failures and throw them after the test suite is completed, which is caught by QUnits global `window.onerror` handler as a "global failure".
rwjblue
force-pushed
the
ensure-context-is-unset
branch
from
1788a1d
to
a96d7d5
Compare
|
I was able to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beforeandafterwhen randomizing test order.setupRegistryis called before it is needed each time.unsetContext()is called during teardown.