Fix issues with IE11 #276
Merged
Fix issues with IE11 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
commented
Dec 15, 2017
| @@ -22,8 +22,8 @@ export default function fillIn(target, text) { | |||
| if (!element) { | |||
| throw new Error(`Element not found when calling \`fillIn('${target}')\`.`); | |||
| } | |||
|
|
|||
| if (!isFormControl(element) && !element.isContentEditable) { | |||
| let isControl = isFormControl(element); | |||
There was a problem hiding this comment.
It turns out that isContentEditable is true for input elements in IE. I did this fix but maybe we have to go back to check if the element has a contenteditable=true attribute
rwjblue
requested changes
Dec 15, 2017
tests/dummy/config/targets.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* eslint-env node */ | |||
| const browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions']; | |||
| const browsers = ['ie 11', 'last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions']; | |||
There was a problem hiding this comment.
We should probably revert this change (to test locally you can use CI=true ember test --server or CI=true ember s -p 0)...
| @@ -0,0 +1 @@ | |||
| export default !window.ActiveXObject && 'ActiveXObject' in window; | |||
There was a problem hiding this comment.
This is great! 👍 I think we should add a comment explaining what it does.
Something like:
// `window.ActiveXObject` returns undefined in IE11 (as well as non-IE browsers)
// whereas `"ActiveXObject" in window` returns `true` in all IE versions
// only IE11 will pass _both_ of these conditions
Fixes linting (to pass CI).
Replace usage of `document.contains` with `document.body.contains` (only elements get `.contains`).
|
OK, pushed some changes / tweaks to address my comments above. |
rwjblue
approved these changes
Dec 15, 2017
|
Now great. Now I need an IE10 vm |
|
Great work here @cibernox! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is still 2 failing tests, but I'm out for the day.