Add documentation dev dependency
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Turbo87
commented
Dec 27, 2017
| provider: pages | ||
| skip_cleanup: true | ||
| local_dir: docs | ||
| github_token: $GITHUB_TOKEN # Set in travis-ci.org dashboard |
There was a problem hiding this comment.
@rwjblue forgot to mention: this env var needs to be set by someone with sufficient privs (aka. not me 🤷♂️)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #285
I haven't tested the CI part yet, but in theory it should be configured so that it automatically builds and deploys the documentation to GitHub Pages whenever a tag is pushed.
Unfortunately http://emberjs.github.io/ember-test-helpers/ is currently directing to a emberjs.com 404 page so I'm not sure if we can actually use GitHub Pages at all 🤔
/cc @locks