Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include selector in waitFor()'s default timeout message #392

Conversation

gabrielgrant
Copy link
Contributor

Reduces ambiguity if a timeout occurs in a test with multiple waitFor()s

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Mind poking at CI to see why it’s failing?

@gabrielgrant
Copy link
Contributor Author

gabrielgrant commented Jul 2, 2018

Looks like a problem with eslint:

$ eslint *.js addon addon-test-support app config lib node-tests server tests test-support
/home/travis/build/emberjs/ember-test-helpers/addon-test-support/@ember/test-helpers/dom/wait-for.js
  18:33  error  Replace `⏎··selector,⏎··{·timeout·=·1000,·count·=·null,·timeoutMessage·}·=·{}⏎` with `selector,·{·timeout·=·1000,·count·=·null,·timeoutMessage·}·=·{}`  prettier/prettier
✖ 1 problem (1 error, 0 warnings)

Didn't change this spacing/formatting, so not sure why that wasn't causing problems before (guessing there's maybe a line-length limit that we're now under?), but just added a commit to fix it

@rwjblue rwjblue merged commit e172fe6 into emberjs:master Jul 9, 2018
@rwjblue
Copy link
Member

rwjblue commented Jul 9, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants