Add container items required for Glimmer. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
emberjs/ember.js#11041 was added to expose |
No doubt. I am hopeful that we can find a way out of the woods while implementing emberjs/rfcs#46. However, if there isn't sufficient support for that, we will need a more narrowly focused alternative to solve registry initialization in Ember (and not here). |
|
@rwjblue btw, you probably realize this, but this is still failing on canary. |
This is getting pretty annoying. We need a *much* better way to deal with these default/fallback container items, but we also need tests to work in Glimmer-land. So, grrr, but YOLO...
rwjblue
force-pushed
the
add-glimmer-default-container-items
branch
from
34808e9
to
87fb7f7
Compare
|
Yep, it required the upstream PR to be merged and published. Should be good now (took a while for Travis to run on the Ember merge commit). |
rwjblue
added a commit
that referenced
this pull request
May 6, 2015
Add container items required for Glimmer.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is getting pretty annoying. We need a much better way to deal with these default/fallback container items, but we also need tests to work in Glimmer-land. So, grrr, but YOLO...