Add ability to opt-out of automatic settledness waiting in teardown. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow things like `ember-qunit`'s upcoming async leak detection, we need to avoid waiting for `settled()`. By default we should continue to effectively `await settled()` but when ember-qunit (and soon ember-mocha) is configured to use async leak detection they can appropriately pass `waitForSettled` when they call `teardownContext` / `teardownRenderingContext` / `teardownApplicationContext`.
rwjblue
force-pushed
the
add-settled-opt-out
branch
from
9a97632
to
7a45874
Compare
Turbo87
reviewed
Dec 10, 2018
Avoid possible timing issues in original tests.
rwjblue
added a commit
to rwjblue/ember-qunit
that referenced
this pull request
Dec 10, 2018
\#### 🚀 Enhancement * [emberjs#498](emberjs/ember-test-helpers#498) Add ability to opt-out of automatic settledness waiting in teardown. ([@rwjblue](https://github.com/rwjblue)) \#### 🐛 Bug Fix * [emberjs#497](emberjs/ember-test-helpers#497) Only customize RSVP's async for Ember older than 1.7. ([@rwjblue](https://github.com/rwjblue)) * [emberjs#481](emberjs/ember-test-helpers#481) Allow ember-cli-htmlbars-inline-precompile 2.x and 1.x ([@mydea](https://github.com/mydea)) \#### 🏠 Internal * [emberjs#491](emberjs/ember-test-helpers#491) TravisCI: Remove deprecated `sudo: false` option ([@Turbo87](https://github.com/Turbo87)) * [emberjs#480](emberjs/ember-test-helpers#480) Extract Prettier configuration to .prettierrc.js file. ([@rwjblue](https://github.com/rwjblue)) * [emberjs#463](emberjs/ember-test-helpers#463) Improve type declarations ([@Turbo87](https://github.com/Turbo87)) \#### Committers: 4 - Francesco Novy ([@mydea](https://github.com/mydea)) - Peter Wagenet ([@wagenet](https://github.com/wagenet)) - Robert Jackson ([@rwjblue](https://github.com/rwjblue)) - Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow things like
ember-qunit's upcoming async leak detection, we need to avoid waiting forsettled(). By default we should continue to effectivelyawait settled()but when ember-qunit (and soon ember-mocha) is configured to use async leak detection they can appropriately passwaitForSettledwhen they callteardownContext/teardownRenderingContext/teardownApplicationContext.