Provide better context for subject() deprecation
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ export default TestModule.extend({ | |||
| this.setupSteps.push(this.setupComponentUnitTest); | |||
| } else { | |||
| this.callbacks.subject = function() { | |||
| throw new Error("component integration tests do not support `subject()`."); | |||
| throw new Error("component integration tests do not support `subject()`. Instead, render the component as if it were HTML: `this.render('<my-component foo=true>');`. For more information, read: https://github.com/switchfly/ember-test-helpers/pull/38"); | |||
There was a problem hiding this comment.
@rwjblue I'm not sure about the language on this, or even if the suggestion is correct.
Once we nail down the language of this warning, I'd gladly add to the README's explanation on integration: true mode.
There was a problem hiding this comment.
Can you remove the link, and suggest reading guides.emberjs.com's Testing -> Testing Components guide?
The outcome of [emberjs#38][38] is undocumented. Raising a deprecation warning for calls to `this.subject` is a good start, but could be improved greatly. [38]: emberjs#38
| @@ -46,7 +46,7 @@ export default TestModule.extend({ | |||
| this.setupSteps.push(this.setupComponentUnitTest); | |||
| } else { | |||
| this.callbacks.subject = function() { | |||
| throw new Error("component integration tests do not support `subject()`."); | |||
| throw new Error("component integration tests do not support `subject()`. Instead, render the component as if it were HTML: `this.render('<my-component foo=true>');`. For more information, read: http://guides.emberjs.com/v2.2.0/testing/testing-components/"); | |||
There was a problem hiding this comment.
@rwjblue replaced the link with http://guides.emberjs.com/v2.2.0/testing/testing-components/
Also, http://guides.emberjs.com/v2.2.0/ looks great!
There was a problem hiding this comment.
kk, seems good, thank you (and sorry for crazy delay here)
rwjblue
added a commit
that referenced
this pull request
Dec 9, 2015
Provide better context for `subject()` deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outcome of #38 is undocumented.
Raising a deprecation warning for calls to
this.subjectis a good start,but could be improved greatly.