refactor(DebugInfo): Changes DebugInfo constructor signature to POJO #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is technically a breaking change, but I think the only external consumer is |
I don't think I agree, the constructor was not exposed as public API (AFAICT only this lib itself was creating instances of DebugInfo) |
|
Sorry, didn't mean to seem so argumentative there! Indeed changing the constructor args is a breaking change, but since we don't (AFAIK) leak the constructor we should be safe. |
|
👍 |
rwjblue
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the
DebugInfoconstructor used to take a series of booleans. This type of signature becomes very hard to use and read, as a succession oftrue/falseparameters doesn't help the reader understand what's required.This PR addresses this by converting the signature to take a POJO, in this case of type
SettledState.