Throw when integration and needs declared #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current test suite is failing and I didn't have time to look into the error that already exist before writing this patch. Once those are resolved I can revisit this patch if there are build issues. |
|
Sorry for the delay here, I think that we have everything fixed up test wise on master. Would you mind rebasing to get Travis to re-run with the updates? |
| @@ -18,6 +18,10 @@ export default Klass.extend({ | |||
| this.name = description || subjectName; | |||
| this.callbacks = callbacks || {}; | |||
|
|
|||
| if (this.callbacks.integration && this.callback.needs) { | |||
There was a problem hiding this comment.
Should be this.callbacks.needs (it is this.callback ATM).
`needs` will switch off integration testing, this is not obvious. If both are declared we should throw a descriptive Error.
rwjblue
added a commit
that referenced
this pull request
Jul 31, 2015
…-needs-declared Throw when integration and needs declared
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needswill switch off integration testing, this is not obvious. Ifboth are declared we should throw a descriptive Error.