Migrate to using @ember/destroyable for teardown.
#914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
approved these changes
Aug 25, 2020
| } | ||
|
|
||
| return nextTickPromise(); | ||
| destroy(context); |
There was a problem hiding this comment.
Were we only waiting for settled before because we were using runloop APIs?
There was a problem hiding this comment.
If you look just below, we are still return await settled() in the finally. I honestly do not know why we were doing it twice.
|
You have a linting failure with an unused import. |
rwjblue
force-pushed
the
use-destroyables
branch
from
13b0aae
to
fb1ce18
Compare
|
Currently blocked by #915 |
rwjblue
force-pushed
the
use-destroyables
branch
from
fb1ce18
to
24967bb
Compare
Moves actual logic from `teardownContext` into `setupContext` by using `registerDestructor` and `associateDestroyableChild`.
rwjblue
force-pushed
the
use-destroyables
branch
from
24967bb
to
b0f94ba
Compare
rwjblue
changed the title
@ember/destroyable for teardown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves actual logic from
teardownContextintosetupContextby usingregisterDestructorandassociateDestroyableChild.