Remove deprecated ember-cli-htmlbars-inline-precompile for v1-x #922
Conversation
|
Tests were passed: https://travis-ci.org/github/emberjs/ember-test-helpers/jobs/728739086 |
| @@ -38,7 +38,7 @@ | |||
| "broccoli-funnel": "^2.0.2", | |||
| "ember-assign-polyfill": "^2.6.0", | |||
| "ember-cli-babel": "^7.7.3", | |||
| "ember-cli-htmlbars-inline-precompile": "^2.1.0", | |||
| "ember-cli-htmlbars": "^4.4.0", | |||
There was a problem hiding this comment.
I think the problem with this (for the 1.x series) is with Node version support.
ember-cli-htmlbars@4 supports Node 8, 10, >= 12, but the 1.x branch of @ember/test-helpers supports Node 6.
https://github.com/ember-cli/ember-cli-htmlbars/blob/v4.4.0/package.json#L95
ember-test-helpers/package.json
Line 90 in 02bb484
There was a problem hiding this comment.
Ok, thanks for the explanation, I see the problem now.
Then just want to share my problem. In my project, I try to upgrade dependencies and receive the next error in tests:
"Could not find module htmlbars-inline-precompile imported from @ember/test-helpers/setup-rendering-context".
I suspect that my PR can solve it or somehow need to use the not stable beta release of the library.
Maybe you or somebody can help me to fix it in another way.
There was a problem hiding this comment.
Looks like it is an issue related to updates in ember-cli-mirage: 1.1.4 => 1.1.6, so this PR can be closed.
In this pull request, I removed usage of ember-cli-htmlbars-inline-precompile in the currently latest stable v1 version.
Inspired by #821