Skip to content

Commit

Permalink
Update ember-cli-typescript to dependency.
Browse files Browse the repository at this point in the history
* Fix types for waitForPromise (returns an RSVP.Promise now)
* Re-run the ember-cli-typescript generator
* Change re-exports to use explicit names (instead of `export * `)
  • Loading branch information
rwjblue committed Feb 26, 2020
1 parent 658e252 commit 1fdebdb
Show file tree
Hide file tree
Showing 7 changed files with 78 additions and 118 deletions.
12 changes: 10 additions & 2 deletions addon/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
export {
WaiterName,
Token,
Primitive,
Waiter,
TestWaiter,
TestWaiterDebugInfo,
PendingWaiterState,
} from './types';

export {
register,
unregister,
Expand All @@ -9,5 +19,3 @@ export {

export { default as buildWaiter } from './build-waiter';
export { default as waitForPromise } from './wait-for-promise';

export * from './types';
3 changes: 2 additions & 1 deletion addon/wait-for-promise.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { DEBUG } from '@glimmer/env';
import { Promise } from 'rsvp';
import buildWaiter from './build-waiter';

const PROMISE_WAITER = buildWaiter('promise-waiter');
Expand All @@ -24,7 +25,7 @@ const PROMISE_WAITER = buildWaiter('promise-waiter');
* }
* }
*/
export default function waitForPromise<T>(promise: Promise<T>, label?: string) {
export default function waitForPromise<T>(promise: Promise<T>, label?: string): Promise<T> {
let result = promise;

if (DEBUG) {
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
},
"dependencies": {
"ember-cli-babel": "^7.18.0",
"ember-cli-typescript": "^3.1.3",
"semver": "^7.1.3"
},
"devDependencies": {
Expand All @@ -47,7 +48,7 @@
"ember-cli-inject-live-reload": "^2.0.2",
"ember-cli-sri": "^2.1.1",
"ember-cli-test-loader": "^3.0.0",
"ember-cli-typescript": "^3.1.3",
"ember-cli-typescript-blueprints": "^3.0.0",
"ember-cli-uglify": "^3.0.0",
"ember-disable-prototype-extensions": "^1.1.3",
"ember-export-application-global": "^2.0.1",
Expand Down
13 changes: 7 additions & 6 deletions tests/unit/wait-for-promise-test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import MockStableError, { overrideError, resetError } from './utils/mock-stable-error';
import { _reset, getPendingWaiterState, waitForPromise } from 'ember-test-waiters';
import { module, test } from 'qunit';
import { Promise } from 'rsvp';
import { _reset, waitForPromise, getPendingWaiterState } from 'ember-test-waiters';
import MockStableError, { resetError, overrideError } from './utils/mock-stable-error';

import { DEBUG } from '@glimmer/env';
import { Promise } from 'rsvp';

if (DEBUG) {
module('wait-for-promise', function(hooks) {
Expand All @@ -12,7 +13,7 @@ if (DEBUG) {
});

test('waitForPromise wraps and registers a waiter', async function(assert) {
let promise: Promise<{}> = new Promise(resolve => {
let promise = new Promise(resolve => {
resolve();
});

Expand All @@ -38,7 +39,7 @@ if (DEBUG) {
});

test('waitForPromise transitions waiter to not pending even if promise throws', async function(assert) {
let promise: Promise<{}> = Promise.resolve().then(() => {
let promise = Promise.resolve().then(() => {
throw new Error('Promise threw');
});

Expand All @@ -50,7 +51,7 @@ if (DEBUG) {
});

test('waitForPromise transitions waiter to not pending even if promise throws when thenable wrapped', async function(assert) {
let promise: Promise<{}> = Promise.resolve().then(() => {
let promise = Promise.resolve().then(() => {
throw new Error('Promise threw');
});

Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"inlineSources": true,
"baseUrl": ".",
"module": "es6",
"experimentalDecorators": true,
"paths": {
"dummy/tests/*": [
"tests/*"
Expand Down
6 changes: 6 additions & 0 deletions types/global.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Types for compiled templates
declare module 'ember-test-waiters/templates/*' {
import { TemplateFactory } from 'htmlbars-inline-precompile';
const tmpl: TemplateFactory;
export default tmpl;
}
Loading

0 comments on commit 1fdebdb

Please sign in to comment.