Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TS issue with mismatched type for deprecate #280

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

scalvert
Copy link
Collaborator

Fixes type mismatch introduced in #272.

@scalvert scalvert added the bug Something isn't working label Jul 12, 2021
@scalvert scalvert requested a review from rwjblue July 12, 2021 15:27
@NullVoxPopuli
Copy link
Sponsor Contributor

should an issue be opened to ember-cli-typescript as well?

@scalvert
Copy link
Collaborator Author

What specifically do you think that issue should call out?

@NullVoxPopuli
Copy link
Sponsor Contributor

To update https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ember__debug/index.d.ts#L71 to match the current API so that test-waiters can eventually remove the override?

@scalvert
Copy link
Collaborator Author

scalvert commented Jul 12, 2021

Oh, so that would be in DefinitelyTyped, not ember-cli-typescript, right? Also, I believe there's already a PR for this: DefinitelyTyped/DefinitelyTyped#52397

The PR was closed, but I can re-open it and try to work on it.

@scalvert
Copy link
Collaborator Author

I've also further updated the call site for deprecate since the since property was incorrectly called (it's an object, not a string).

@rwjblue rwjblue merged commit 103eb95 into master Jul 13, 2021
@rwjblue rwjblue deleted the fix-deprecate-type branch July 13, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants