Fix Failing Tests resulting from ember-concurrency v2 bump #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
ember-concurrency-fun
branch
2 times, most recently
from
29b98ab
to
71bb600
Compare
1) treat `continue()` not as an idempotent function, but rather as a once time resource. This helps detect failures, specifically ones where we are cooperating with another co-routine. In-practice, this means `continue()` will throw if invoked twice for the same continuation 2) `continue()` now returns a promise, which tests now await rather than Promise.resolve. This enables the generator itself to dictate when the the active continuation has come to an end. — After debugging, it really just came down to the fact that `await Promise.resolve()` and the `yieldable` used in this test implicitly depended on something they really should not have. Ember 3.16 and 3.20 had slightly different glimmer dirty-tracking behaviors, which resulted in the mixture of native promises and ember auto-run setTimeouts creating a situation where the precariousness of the relationship between the above mentioned operations was exposed. The proper way to address this is to ensure the test code makes that relationship explicit. I suspect ember-concurrencies new yieldable may be the recommended approach, but this should suffice to get the tests green again. I have also brain dumped all this on poor Steve, who may look into the yieldable stuff.
stefanpenner
force-pushed
the
ember-concurrency-fun
branch
from
71bb600
to
a4d3b9d
Compare
|
cc/ @bendemboski for visibility into the test issue. |
scalvert
approved these changes
Aug 16, 2021
scalvert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
treat
continue()not as an idempotent function, but rather as a once time resource. This helps detect failures, specifically ones where we are cooperating with another co-routine. In-practice, this meanscontinue()will throw if invoked twice for the same continuationcontinue()now returns a promise, which tests now await rather than Promise.resolve. This enables the generator itself to dictate when the the active continuation has come to an end.—
After debugging, it really just came down to the fact that
await Promise.resolve()and theyieldableused in this test implicitly depended on something they really should not have. Ember 3.16 and 3.20 had slightly different glimmer dirty-tracking behaviors, which resulted in the mixture of native promises and ember auto-run setTimeouts creating a situation where the precariousness of the relationship between the above mentioned operations was exposed.The proper way to address this is to ensure the test code makes that relationship explicit. I suspect ember-concurrencies new yieldable may be the recommended approach, but this should suffice to get the tests green again.
I have also brain dumped all this on poor Steve, who may look into the yieldable stuff.