Merge pull request #10712 from ef4/fix-10710

[BUGFIX beta] render helper should defer to View when choosing template
emberjs · Mar 24, 2015 · 12fbc86 · 12fbc86
2 parents 4cd4c7c + c226046
commit 12fbc86
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 9 deletions.
diff --git a/packages/ember-routing-htmlbars/lib/helpers/render.js b/packages/ember-routing-htmlbars/lib/helpers/render.js
@@ -124,8 +124,19 @@ export function renderHelper(params, hash, options, env) {
   name = name.replace(/\//g, '.');
   // \ legacy slash as namespace support
 
+  var templateName = 'template:' + name;
+  Ember.assert(
+    "You used `{{render '" + name + "'}}`, but '" + name + "' can not be " +
+    "found as either a template or a view.",
+    container._registry.has("view:" + name) || container._registry.has(templateName) || !!options.template
+  );
 
-  view = container.lookup('view:' + name) || container.lookup('view:default');
+  var template = options.template;
+  view = container.lookup('view:' + name);
+  if (!view) {
+    view = container.lookup('view:default');
+    template = template || container.lookup(templateName);
+  }
 
   // provide controller override
   var controllerName;
@@ -174,14 +185,6 @@ export function renderHelper(params, hash, options, env) {
 
   hash.viewName = camelize(name);
 
-  var templateName = 'template:' + name;
-  Ember.assert(
-    "You used `{{render '" + name + "'}}`, but '" + name + "' can not be " +
-    "found as either a template or a view.",
-    container._registry.has("view:" + name) || container._registry.has(templateName) || !!options.template
-  );
-  var template = options.template || container.lookup(templateName);
-
   if (router && !initialContext) {
     router._connectActiveView(name, view);
   }

diff --git a/packages/ember-routing-htmlbars/tests/helpers/render_test.js b/packages/ember-routing-htmlbars/tests/helpers/render_test.js
@@ -535,3 +535,23 @@ QUnit.test("throws an assertion if {{render}} is called with a literal for a mod
     runAppend(view);
   }, "The second argument of {{render}} must be a path, e.g. {{render \"post\" post}}.");
 });
+
+QUnit.test("{{render}} helper should let view provide its own template", function() {
+  var template = "{{render 'fish'}}";
+  var controller = EmberController.extend({ container: container });
+  view = EmberView.create({
+    controller: controller.create(),
+    template: compile(template)
+  });
+
+  container._registry.register('template:fish', compile('Hello fish!'));
+  container._registry.register('template:other', compile('Hello other!'));
+
+  container._registry.register('view:fish', EmberView.extend({
+    templateName: 'other'
+  }));
+
+  runAppend(view);
+
+  equal(view.$().text(), 'Hello other!');
+});