Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide issue? i should use which kind of event_name style, keyPress or key-press? #10713

Closed
Jokery opened this issue Mar 24, 2015 · 2 comments
Closed

guide issue? i should use which kind of event_name style, keyPress or key-press? #10713

Jokery opened this issue Mar 24, 2015 · 2 comments

Comments

@Jokery
Copy link

Jokery commented Mar 24, 2015

in input guide
it says Event Names must be dasherized when assigned to on.
and in action guide
it says In general, two-word event names (like keypress) become keyPress.
i'm confused
@knownasilya
Copy link
Contributor

@Jokery when using as an attribute on an element/in actions, use dasherized, but in code use camelCased.

This was referenced Mar 24, 2015
Closed
Closed
Serabe added a commit to Serabe/guides that referenced this issue Jul 10, 2015
@Serabe
Fix camelized event names in template/actions.
6f28073 
Event names were camelized in actions instead of dasherized. This fix also
expects emberjs/ember.js#11711 (or similar) to fix the API documentation as
well.

This is the actual fix for emberjs/ember.js#10713 continuing the discussion in
Serabe added a commit to Serabe/guides that referenced this issue Jul 10, 2015
@Serabe
Fix camelized event names in template/actions.
70b1e2e 
Event names were camelized in actions instead of dasherized. This fix also
expects emberjs/ember.js#11711 (or similar) to fix the API documentation as
well.

This is the actual fix for emberjs/ember.js#10713 continuing the discussion in
emberjs#83.
@Serabe Serabe mentioned this issue Jul 10, 2015
Merged
michaelrkn pushed a commit to emberjs/guides that referenced this issue Jul 23, 2015
@Serabe @michaelrkn
Fix camelized event names in template/actions.
2481f8e 
Event names were camelized in actions instead of dasherized. This fix also
expects emberjs/ember.js#11711 (or similar) to fix the API documentation as
well.

This is the actual fix for emberjs/ember.js#10713 continuing the discussion in
#83.
michaelrkn pushed a commit to emberjs/guides that referenced this issue Jul 28, 2015
@Serabe @michaelrkn
Fix camelized event names in template/actions.
3afb1a1 
Event names were camelized in actions instead of dasherized. This fix also
expects emberjs/ember.js#11711 (or similar) to fix the API documentation as
well.

This is the actual fix for emberjs/ember.js#10713 continuing the discussion in
#83.
@rwjblue
Copy link
Member

rwjblue commented Aug 16, 2015

Fixed by emberjs/guides#418.

@rwjblue rwjblue closed this as completed Aug 16, 2015
locks pushed a commit to emberjs/guides that referenced this issue Oct 9, 2015
@Serabe @locks
Fix camelized event names in template/actions.
4d935ed 
Event names were camelized in actions instead of dasherized. This fix also
expects emberjs/ember.js#11711 (or similar) to fix the API documentation as
well.

This is the actual fix for emberjs/ember.js#10713 continuing the discussion in
#83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @knownasilya @Jokery