New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templating] UndefinedLiteral Coerced To Null #14016
Comments
I was surprised by this recently when writing a helper test to handle My vote would be to change the behavior to pass the expected |
@mitchlloyd This is my predicament as well. |
@chadhietala does glimmerjs/glimmer-vm#252 resolve this issue? |
No waiting on glimmerjs/glimmer-vm#255 |
glimmerjs/glimmer-vm#255 has landed but I want to keep this open until we bump the version on glimmer. |
Closed by #14060 |
New glimmer engines makes difference between null and undefined values. Note that previous behaviour was an accident (cf. emberjs/ember.js#14016) This commit updates tests to reflect that. Was necessary to add conditional tests depending on the ember version. This version check relies on the ``ember-version-is`` addon.
New glimmer engines makes difference between null and undefined values. Note that previous behaviour was an accident (cf. emberjs/ember.js#14016) This commit updates tests to reflect that. Was necessary to add conditional tests depending on the ember version. This version check relies on the ``ember-version-is`` addon.
Currently in both rendering engines UndefinedLiterals are coerced to
null
. This seems incorrect, however there may be application code that is dependent on this incorrectness, which may lead to non-obvious breakages.Example:
This issue is a placeholder to see if anybody is surprised by this or has code that coerces
null
back intoundefined
.The text was updated successfully, but these errors were encountered: