Router Service: Default Query Param Values are Serialized to the URL

[iezer]

I have a route with a default query param specified in the controller. If I transition to this route using a link-to, a controller action, or a route action, the default query param is not serialized to the URL. However, if I transition by using the router service, by calling router.transitionTo(...), the default value does appear in the URL.

Here's a reproduction twiddle.

Possibly related to #16594, although I don't get any errors in the console.

[Exelord]

Confirmed!

[iezer]

Turns out this is deliberate behavior described in the Router Service RFC. It's implemented here as part of this commit and there's even a test.

This behavior is not documented anywhere other than the RFC so I'll open a PR with some documentation.

[iezer]

@rwjblue the Router Service RFC describes adding a symbol Ember.DEFAULT_VALUE exposed as import { DEFAULT_VALUE } from 'ember-routing'; for hiding default query params when using the Router service, but it seems like this was never implemented. Is it still part of the plan? If so I'd be happy to work on it.

[iezer]

Adding @miguelcobain and @chadhietala since you've worked on the RFC and Router service and may have some comments.

[rwjblue]

Docs were fixed in
#16977, considering this closed...