Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest - Remove canary feature flags that have been enabled for at least one version #19202

Closed
6 tasks
jenweber opened this issue Oct 16, 2020 · 3 comments
Closed
6 tasks

Comments

@jenweber
Copy link
Contributor

When new features are in development, they are often feature flagged. When they are done, the feature flag is set to true. After the flag has been true in at least one minor release, the feature flag can be removed.

This ticket can be worked on by multiple people. If you would like to help, please comment with which flag you are working on.

To-do:

  • Read the comments on this issue to see which flags are already being worked on by other contributors

  • Find a feature flag listed in this file that is set to true. Look at the previous minor release of Ember. If it was true in that version too, go to the next step! If not, please comment on this issue to say so, and then choose another flag.

  • Search the codebase for all uses of that feature flag. Remove the code that would not have been hit if the flag was true. Then, remove the flag itself from the code as well as from the canary-features list

  • Open a PR and link to this issue from it

    • EMBER_GLIMMER_SET_COMPONENT_TEMPLATE
    • EMBER_ROUTING_MODEL_ARG
    • EMBER_CACHE_API
    • EMBER_DESTROYABLES
    • EMBER_GLIMMER_HELPER_MANAGER
    • EMBER_GLIMMER_INVOKE_HELPER
@andreisebastianc
Copy link
Contributor

EMBER_GLIMMER_INVOKE_HELPER was added after 3.2.2

@andreisebastianc
Copy link
Contributor

EMBER_GLIMMER_HELPER_MANAGER was added after 3.2.2

@locks
Copy link
Contributor

locks commented Mar 13, 2022

All done for some time!

@locks locks closed this as completed Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants