Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove EMBER_ROUTING_MODEL_ARG feature flag #19206

Conversation

andreisebastianc
Copy link
Contributor

@andreisebastianc andreisebastianc commented Oct 16, 2020

#18060

#19202

Was true in 3.21.0

@andreisebastianc andreisebastianc force-pushed the clean-ember-routing-model-arg-feature-flag-18060 branch from 7cef674 to 9f86e48 Compare October 16, 2020 14:04
@rwjblue
Copy link
Member

rwjblue commented Oct 16, 2020

Looks like this needs a rebase, @andreisebastianc would you mind rebasing and fixing up the conflicts?

@andreisebastianc andreisebastianc force-pushed the clean-ember-routing-model-arg-feature-flag-18060 branch from 9f86e48 to 02f092a Compare October 17, 2020 04:46
@andreisebastianc
Copy link
Contributor Author

Looks like this needs a rebase, @andreisebastianc would you mind rebasing and fixing up the conflicts?

Done.

@pzuraq pzuraq merged commit 6c4407f into emberjs:master Oct 19, 2020
@pzuraq
Copy link
Contributor

pzuraq commented Oct 19, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants