-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need route-active
sexpr for finer-grained control over whether a route is active
#4447
Comments
@beerlington - FYI - it is my understanding that sticky query-params are going to be removed in the next iteration. |
@beerlington sorry it took me so long to get around to this, but I understand what you're asking and I'm having trouble thinking of the right solution... seems like we're caught between two desirable behaviors for taking provided query param values into account when computing whether a link is active. If you had a paginated list of articles, and you were on page 2, and I think the full solution to this involves using an s-expression helper that you can pass in as a value to In the meantime, you can do the following hacky thing: http://jsbin.com/zopixugo/4/edit |
route-active
sexpr for finer-grained control over whether a route is active
Closing this as we have an API to support this use case on master now; we can discuss a feature proposal for this at discuss.emberjs.com if it makes sense. Example of all the ways you can configure QPs: http://jsbin.com/ucanam/5379 |
👍 thanks for all the hard work, very much appreciated! |
I'm not sure if this is a bug, expected behavior, or I'm just misusing the "clearing" functionality for query-params-new. When I clear the params on a link-to helper by passing
false
for the values, the index link is no longer active when params are used in other links within the index template.That description isn't great, but if you look at the following example, you'll see that the Dogs index link is no longer active when a "name" or "breed" parameter is active. This is not the case for the Cats index link. I would expect the Dogs link to remain active since I am still within the DogsRoute.
http://emberjs.jsbin.com/zopixugo/1
The text was updated successfully, but these errors were encountered: