Ember's enumerable contains should align with ES7 Array#contains.

[jdalton]

At the moment Ember's contains does not match NaN values or support a fromIndex like the ES7 Array#contains does. This can cause an inconsistency when Ember adds Array.prototype.contains.

[fivetanley]

👍 thanks! we'll get it fixed asap

[jdalton]

Rock! I made a jsbin for an unrelated Underscore issue that shows this. Just open the web console and try [NaN].contains(NaN) in a non-Firefox-Nightly browser to see it report false. Then in Firefox Nightly to see it report true (as it's using native Array#contains in FF nightly).

[stefanpenner]

@jdalton thanks for the headsup, we appreciate it!

[stefanpenner]

i have a fix, will push once i get to work.

[wagenet]

@stefanpenner can this be closed?

[stefanpenner]

I forgot about #9262, will complete

[xtian]

This should be changed to Enumerable#includes and aliased to contains for back-compat as the spec has changed: https://github.com/tc39/Array.prototype.includes#status

[jdalton]

Ya, though might hold off a bit. As far as I know the TC39 chose includes as an alternative without doing any crawling to estimate potential conflicts so it will be an implement-and-see situation similar to contains.

[wycats]

@jdalton 👍