Introduce an ApplicationInstance-specific registry to Boot Cleanup WIP #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,23 +18,34 @@ var VALID_FULL_NAME_REGEXP = /^[^:]+.+:[^:]+$/; | |||
| @class Registry | |||
| */ | |||
| function Registry(options) { | |||
| this.failover = options && options.failover ? options.failover : null; | |||
There was a problem hiding this comment.
This is a total bikeshed, but I'm not totally in love with the term "failover." To me, a failover implies latch-like behavior: once the "fail" has occurred, you switch everything over to the failover. For example, if the power goes out, you have a "failover" generator that everything switches to.
In this case, it's not really a failover per se… it just looks in its local one first, then expands its search to the parent registry if it's available. Perhaps this terminology is controversial, but I think I'd almost prefer parentRegistry to failover.
There was a problem hiding this comment.
ok, fallback it is - thanks @rwjblue!
A registry's fallback registry resolves registrations and injections when no matches can be found.
The instance's registry sets its fallback to the corresponding application's registry.
dgeb
force-pushed
the
app-instance-registry
branch
from
3a6cfc2
to
c771d3c
Compare
Ensure that `name` and `type` are valid after initial parsing and before any post-parsing mutations might be performed. This fixes a problem in which mutations are performed to the cached object (e.g. "route:basic" -> "route:") and then the validation of the mutated object fail when it's accessed a second time. It's also more efficient, since validation only occurs once.
dgeb
force-pushed
the
app-instance-registry
branch
from
c771d3c
to
a162f86
Compare
|
Bless you child. 🙏 |
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ApplicationInstance-specific registry uses its corresponding Application's registry as a failover to resolve registrations and injections.
Soon, this registry will be abstracted behind proxies such as
registerandinjecton the instance itself.cc @wycats @tomdale