Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Glimmer Engine #10501

Merged
merged 321 commits into from May 5, 2015
Merged

Implement Glimmer Engine #10501

merged 321 commits into from May 5, 2015
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Apr 2, 2015

  1. Made more {{#view}} tests pass

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    22c7c6a View commit details
    Browse the repository at this point in the history
  2. Attrs, scope and view destruction cleanup

    This commit fixes several edge cases in how scope was managed in
    templates, how attrs are looked up, and how views are cleaned up,
    particularly the willDestroyElement user hook.
    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    b504a00 View commit details
    Browse the repository at this point in the history
  3. Take machete to inBuffer state

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    907910f View commit details
    Browse the repository at this point in the history
  4. Implement {{collection}} helper

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    d65c7cb View commit details
    Browse the repository at this point in the history
  5. Unpend passing collection tests

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    f39428f View commit details
    Browse the repository at this point in the history
  6. Helper for finding pending tests that now pass

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    f9bb21a View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    ef9d51e View commit details
    Browse the repository at this point in the history
  8. Left off a bunch of new files

    wycats authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    4d2e775 View commit details
    Browse the repository at this point in the history
  9. Get more tests passing

    wycats authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    c7ab85c View commit details
    Browse the repository at this point in the history
  10. Fix style errors

    mmun authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    3e61a6a View commit details
    Browse the repository at this point in the history
  11. Mark 3 regressions as skipped

    mmun authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    0346b9b View commit details
    Browse the repository at this point in the history
  12. Get more tests passing

    wycats authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    72bbc6f View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    9ba35a6 View commit details
    Browse the repository at this point in the history
  14. Bump htmlbars version

    mmun authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    f23f4cd View commit details
    Browse the repository at this point in the history
  15. Update HTMLBars to v0.12.0.

    No longer requires `npm link` for HTMLBars.
    rwjblue authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    f6640d7 View commit details
    Browse the repository at this point in the history
  16. Fix rebase conflicts and get tests passing

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    2dd0093 View commit details
    Browse the repository at this point in the history
  17. Copy the full SHA
    a1bff06 View commit details
    Browse the repository at this point in the history
  18. Copy the full SHA
    df2e6a9 View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    6d171bb View commit details
    Browse the repository at this point in the history
  20. Rerender {{with}} when param changes

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    992f4af View commit details
    Browse the repository at this point in the history
  21. Always set shadowScope’s view property

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 2, 2015
    Copy the full SHA
    19cd545 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2015

  1. Fix yield in nested views

    Tom Dale and Yehuda Katz authored and tilde-engineering committed Apr 3, 2015
    Copy the full SHA
    bfa40e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2015

  1. Copy the full SHA
    34e28a2 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7cc0894 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a3b9668 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    e1fb347 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    8da40d9 View commit details
    Browse the repository at this point in the history
  6. Allow Handlebars compat helpers to specify additional dep keys.

    In Ember.Handlebars helpers it is possible to add additional dependent
    keys:
    
    ```javascript
    Ember.Handlebars.helper('capitalize-name', function(value) {
      return get(value, 'name').toUpperCase();
    }, 'name');
    ```
    
    ---
    
    Unfortunately, the area that we know about the render node and can add
    more dependent keys, had no knowledge of the individual helper being rendered.
    
    Thsi commit adds a `findHelper` call to `linkRenderNode` so that we can
    determine if additional dependent keys are needed. This is sub-optimal
    because the additional `findHelper` may have a negative impact on render
    speed, but a better solution is not currently possible.
    rwjblue committed Apr 6, 2015
    Copy the full SHA
    edcb457 View commit details
    Browse the repository at this point in the history
  7. Process fooBinding in general.

    Previously, the `TransformOldBindingSyntax` AST walker was only
    processing `{{view}}` invocations. This change makes it process all
    helper invocation, and updates a number of related tests.
    
    In order to do that, we had to change the asserts and deprecations in
    the transform so that when the `loc` information is not present no
    errors are thrown.
    rwjblue committed Apr 6, 2015
    Copy the full SHA
    878f2cf View commit details
    Browse the repository at this point in the history
  8. Fix debugger keyword

    mmun committed Apr 6, 2015
    Copy the full SHA
    5e19bfa View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    7e338d0 View commit details
    Browse the repository at this point in the history
  10. Update to use new _itemViewTemplate for CollectionView test.

    The `{{collection}}` helper sets this automatically, so we need to
    ensure the tests follow suit.
    rwjblue committed Apr 6, 2015
    Copy the full SHA
    6401464 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    b120eb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2015

  1. Copy the full SHA
    29e6eae View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c868b10 View commit details
    Browse the repository at this point in the history
  3. Get node tests running.

    Some are still skipped, but will require further thought/details on
    passing the renderer through to all children in
    `ComponentNode.prototype.createOrUpdateComponent`.
    rwjblue committed Apr 7, 2015
    Copy the full SHA
    3648872 View commit details
    Browse the repository at this point in the history
  4. Remove unused import.

    Fixes JSHint error.
    rwjblue committed Apr 7, 2015
    Copy the full SHA
    5669af5 View commit details
    Browse the repository at this point in the history
  5. Enable LOG_VIEW_LOOKUPS for {{outlet}} keyword.

    Note: that {{outlet}} templates without a view instance do not get a
    default view any longer (the template is just rendered).
    rwjblue committed Apr 7, 2015
    8
    Copy the full SHA
    89cf0a9 View commit details
    Browse the repository at this point in the history
  6. 1
    Copy the full SHA
    5e1787a View commit details
    Browse the repository at this point in the history
  7. Restore Component.prototype.targetObject.

    This is needed to target the parentView.controller with the action (when
    it is provided in the template).
    
    It is possible that in 2.x this conceptually needs to change from
    `parentView.controller` to something else, but the general idea will
    still remain.
    rwjblue committed Apr 7, 2015
    Copy the full SHA
    d22789e View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2015

  1. Copy the full SHA
    386d8e7 View commit details
    Browse the repository at this point in the history
  2. Refactor stream dependencies

    Stream dependencies now mock the Stream interface which accomodates some
    leaner code.
    
    Stream now has a revalidate hook which is used for manual dependency
    management. This hook is invoked in two cases:
    
      1. The stream just activated.
      2. The stream is already activate and is about to re-compute.
    mmun committed Apr 8, 2015
    Copy the full SHA
    f12ae8b View commit details
    Browse the repository at this point in the history
  3. Add deactivate hook in Stream, fix KeyStream observers lifecycle

    The commit ensures observers for a KeyStream are removed correctly.
    A new revalidate hook was introduced as a place to clean up any manual
    dependencies. This hook is invoked when the last subscriber is removed
    (including when the stream is being destroyed).
    mmun committed Apr 8, 2015
    Copy the full SHA
    218eab7 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2015

  1. Copy the full SHA
    c8e340b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    fa9ccb5 View commit details
    Browse the repository at this point in the history
  3. Fixing outlets inside {{render}} helper

    Four new passing tests.
    ef4 committed Apr 9, 2015
    Copy the full SHA
    dbb7dae View commit details
    Browse the repository at this point in the history
  4. Bump htmlbars to 0.12.1

    mmun committed Apr 9, 2015
    Copy the full SHA
    50d54c1 View commit details
    Browse the repository at this point in the history
  5. Bump htmlbars to 0.13.0

    This commit modifies the AST transforms to match the Handlebars 3.0 AST.
    mmun committed Apr 9, 2015
    Copy the full SHA
    826c31f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2015

  1. Fix {{render}}'s ownerView

    And remove the workarounds from it being wrong.
    ef4 committed Apr 10, 2015
    Copy the full SHA
    be60dae View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2015

  1. Copy the full SHA
    b857386 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e697ef3 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2015

  1. implement textarea keyword

    Three more passing tests
    ef4 committed Apr 12, 2015
    Copy the full SHA
    5d95e7b View commit details
    Browse the repository at this point in the history
  2. drop unused argument

    ef4 committed Apr 12, 2015
    Copy the full SHA
    51a560a View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e01d5df View commit details
    Browse the repository at this point in the history
  4. Updating assertion language

    I don't see a reason to bend over backwards to support the exact same
    assertion language for this (deprecated) feature. This new message is
    sufficiently clear.
    ef4 committed Apr 12, 2015
    1
    Copy the full SHA
    a770db3 View commit details
    Browse the repository at this point in the history
  5. drop unused code

    ef4 committed Apr 12, 2015
    Copy the full SHA
    2cb9069 View commit details
    Browse the repository at this point in the history
  6. support {{outlet viewClass=...}}

    ef4 committed Apr 12, 2015
    Copy the full SHA
    7487ffb View commit details
    Browse the repository at this point in the history
  7. fix another outlet view test

    ef4 committed Apr 12, 2015
    Copy the full SHA
    0e90220 View commit details
    Browse the repository at this point in the history
  8. fix another outlet assertion

    ef4 committed Apr 12, 2015
    Copy the full SHA
    7936130 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    2b9d27e View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2015

  1. Copy the full SHA
    c3ae1ad View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    c1ff5b3 View commit details
    Browse the repository at this point in the history
  3. documenting non-obvious code

    ef4 committed Apr 13, 2015
    Copy the full SHA
    26438c4 View commit details
    Browse the repository at this point in the history
  4. Dropping dead code

    As pointed out by @mitchlloyd in #10871.
    ef4 committed Apr 13, 2015
    Copy the full SHA
    e926e8a View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    d13a124 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2015

  1. Merge branch 'master-before-tomhuda' into ir-before-tomhuda

    Conflicts:
    	packages/ember-routing-htmlbars/lib/helpers/render.js
    	packages/ember-template-compiler/lib/plugins/transform-each-in-to-hash.js
    	packages/ember-views/lib/attr_nodes/attr_node.js
    ef4 committed Apr 14, 2015
    Copy the full SHA
    31168bb View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ce6c868 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    81d17c5 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1d842b6 View commit details
    Browse the repository at this point in the history
  5. post-merge cleanup

    ef4 committed Apr 14, 2015
    Copy the full SHA
    3ef586a View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    5e52034 View commit details
    Browse the repository at this point in the history
  7. Fix unbound keyword

    This commit also adds several tests for the path and helper usages of
    the subexpression form, e.g.
    
    ```hbs
    {{capitalize (unbound  foo)}}
    ```
    
    and
    
    ```hbs
    {{capitalize (unbound if foo bar baz)}}
    ```
    mmun authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    508d9de View commit details
    Browse the repository at this point in the history
  8. Add skipped test for compat mode attrs-proxy.

    rwjblue authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    36225a2 View commit details
    Browse the repository at this point in the history
  9. Fix typo in compat mode attrs test.

    rwjblue authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    ad7e537 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    66acf7f View commit details
    Browse the repository at this point in the history
  11. Get Ember.Select tests passing

    tomdale authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    764a138 View commit details
    Browse the repository at this point in the history
  12. Set component props to attrs if defined

    tomdale authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    0c8c573 View commit details
    Browse the repository at this point in the history
  13. Fix last textarea test

    mmun authored and ef4 committed Apr 14, 2015
    Copy the full SHA
    8728fd1 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2015

  1. Fix current node tests.

    rwjblue committed Apr 15, 2015
    Copy the full SHA
    c692bd0 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6153cd8 View commit details
    Browse the repository at this point in the history
  3. Unify legacy class binding into AST preprocessor

    There are several paths and microsyntaxes for creating class name
    bindings for a component’s element via Handlebars. For example:
    
    `{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
    
    With HTMLbars, these have been deprecated in favor of a single API:
    
    `{{view class=“hello foo (if isApp ‘is-an-app’)”}}`
    
    This commit rewrites the AST of templates that contain the old syntax
    into the new syntax at template compile time.
    tilde-engineering authored and tomdale committed Apr 15, 2015
    Copy the full SHA
    47ddf42 View commit details
    Browse the repository at this point in the history
  4. ContainerView should inherit from View

    While it was a noble effort, the attempt to have ContainerView subclass
    Component did not work because it broke propagation of the `controller`
    template keyword.
    tilde-engineering authored and tomdale committed Apr 15, 2015
    Copy the full SHA
    8e56b7f View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    2823dd9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2015

  1. Update HTMLBars to 0.13.1.

    Updates HTMLBars to ensure that initially undefined/null
    `attributeBindings` are not set on the views element.
    rwjblue committed Apr 16, 2015
    Copy the full SHA
    9efd004 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b07d55c View commit details
    Browse the repository at this point in the history
  3. Wrap set in run loop

    mitchlloyd committed Apr 16, 2015
    Copy the full SHA
    9c33444 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #10886 from mitchlloyd/html-class-spacing

    Fix class spacing for classNameBindings
    rwjblue committed Apr 16, 2015
    Copy the full SHA
    55ece9f View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    c43cb49 View commit details
    Browse the repository at this point in the history
  6. Update link-render-node to handle missing params.

    The `{{component}}` keyword specifies `null` as `params` (since a
    component cannot receive ordered arguments).  This commit simply adds a
    guard to ensure we do not attempt to access `params.length` when
    `params` is `null`.
    rwjblue committed Apr 16, 2015
    Copy the full SHA
    6ff3999 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    d2a9f02 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    188d00c View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    9ce2845 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    6deadbe View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    db465ae View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    c7f67e8 View commit details
    Browse the repository at this point in the history
  13. dropping dead code

    this is all old implementation of pre-glimmer outlet behavior
    ef4 committed Apr 16, 2015
    Copy the full SHA
    a180c80 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    86bdbc6 View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    85ff427 View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    8cde4d3 View commit details
    Browse the repository at this point in the history
  17. Remove invalid test

    mmun committed Apr 16, 2015
    Copy the full SHA
    c056148 View commit details
    Browse the repository at this point in the history
  18. Merge pull request #10888 from mitchlloyd/is-visible-fixes

    isVisible fixes
    rwjblue committed Apr 16, 2015
    Copy the full SHA
    7324b93 View commit details
    Browse the repository at this point in the history
  19. Copy the full SHA
    55dd117 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2015

  1. Copy the full SHA
    62df0e5 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d8a8679 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    701f11f View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    03c1710 View commit details
    Browse the repository at this point in the history
  5. Fix a test using an undefined context

    Context-changing helpers no longer allow an undefined context. Instead,
    null is substituted for the context.
    mmun committed Apr 17, 2015
    Copy the full SHA
    f73264d View commit details
    Browse the repository at this point in the history
  6. Remove ember-metal-views tests

    These tests were removed because they were only testing a stub renderer
    defined in the tests.
    mmun committed Apr 17, 2015
    Copy the full SHA
    14d15f4 View commit details
    Browse the repository at this point in the history
  7. Remove unused AttrNode.

    rwjblue committed Apr 17, 2015
    Copy the full SHA
    7d342b6 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    7ce75ed View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2015

  1. WIP on {{each itemController}}

    tilde-engineering authored and tomdale committed Apr 18, 2015
    Copy the full SHA
    e2ea5f0 View commit details
    Browse the repository at this point in the history
  2. Completely remove the concept of isVirtual

    MetamorphView (and the Metamorph mixin) are the final bastion of
    virtual views. This commit removes much of their use.
    
    MetamorphView had two behaviors: First, it was tagless. Second, it was
    not included in the view hierarchy. The first concept (taglessness) is
    still valid in Ember post-Glimmer. For this, we use `tagName: ''`.
    
    The second concept (virtual views) is not longer present. So views which
    previously used MetamorphView will not longer be able to escape the view
    hierarchy. In most cases, the intent was likely to be tagless and being
    virtual was simply a side effect.
    
    OutletView and EachView will now be present in childViews and will be
    parentViews.
    
    `{{render` used to always create a view. Now, it will only create a view
    if one is set by the user. By default it is only a componentNode and has
    no view at all.
    
    The final spot MetamorphViews are used it for the default itemView and
    emptyView on EachView. This should be easy to address in a manner
    similar to {{render: If the user does not specify a view, none should be
    required.
    
    After this, MetamorphView will no longer be used by internals.
    mixonic authored and rwjblue committed Apr 18, 2015
    Copy the full SHA
    6368254 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #10903 from mixonic/idempotent-rerender-no-virtual

    Completely remove the concept of isVirtual
    rwjblue committed Apr 18, 2015
    Copy the full SHA
    44b219c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2015

  1. Copy the full SHA
    f892dc8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    9d923a6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    8a92672 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    06aab7c View commit details
    Browse the repository at this point in the history
  5. Make createElement work without view entering inDOM state

    createElement requires that a view be rendered without the lifecycle
    hooks being rendered. This leaves it in the hasElement state instead of
    moving to inDOM as a normal render would.
    mixonic committed Apr 19, 2015
    Copy the full SHA
    011b876 View commit details
    Browse the repository at this point in the history
  6. Clean up some lifecycle tests

    mixonic committed Apr 19, 2015
    Copy the full SHA
    2d3b012 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    09752c4 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    03b420b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2015

  1. Copy the full SHA
    bbc901d View commit details
    Browse the repository at this point in the history
  2. drop dead code

    this argument was used by the pre-glimmer OutletView only
    ef4 committed Apr 20, 2015
    Copy the full SHA
    fda7884 View commit details
    Browse the repository at this point in the history
  3. topmost outlet must ensure its child has a DOM element

    This keeps us consistent with the DOM structure we produced
    pre-glimmer. The topmost out ensures that it's child (not itself) always
    has a real View with an element.
    ef4 committed Apr 20, 2015
    Copy the full SHA
    5c5585d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    b325125 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    9ced6d9 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    7e489a6 View commit details
    Browse the repository at this point in the history
  7. Modernize child_views_test

    Use templates instead of render method
    mmun committed Apr 20, 2015
    Copy the full SHA
    9d7ec1a View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    f11e02a View commit details
    Browse the repository at this point in the history
  9. Reimplement willInsertElement

    mmun committed Apr 20, 2015
    Copy the full SHA
    41648d7 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    05ee711 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2015

  1. Split up render_test.js

    - Rename render_test.js to view_test.js.
    - Move conatiner view related tests to container_view_test.js.
    - Remove invalid tests that are overly specific about rerender
      behaviour. There are much more comprehensive tests in view_lifecycle_test.js.
    mmun committed Apr 21, 2015
    Copy the full SHA
    371afb3 View commit details
    Browse the repository at this point in the history
  2. Update HTMLBars.

    rwjblue committed Apr 21, 2015
    Copy the full SHA
    9b1ac59 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    37be98e View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1404ce4 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2015

  1. Copy the full SHA
    54ed612 View commit details
    Browse the repository at this point in the history
  2. Cancel scheduled view#append on view#remove

    If a view is in a ‘preRender’ state (or any state for that matter)
    attempting to destroy the element will effectively make any pending
    view#append operations a noop.
    mitchlloyd committed Apr 22, 2015
    Copy the full SHA
    1f24be6 View commit details
    Browse the repository at this point in the history
  3. Destroy ember views in destroy-render-node hook

    The way `clearRender` works, it won’t call destroy on the top level
    view if given `destroySelf` flag set to false. By moving the
    `view.destroy` call into this hook, we can avoid destroying the top
    level view when it is being cleared by `clearRender`.
    
    The `view.lastResult` check seemed to just happen to work and needed to
    be changed to get more tests passing.
    mitchlloyd committed Apr 22, 2015
    Copy the full SHA
    32d625b View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2015

  1. Merge pull request #10924 from mitchlloyd/view-remove-fixes

    Get more tests with view#remove working
    mmun committed Apr 23, 2015
    Copy the full SHA
    4a072bc View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2015

  1. Tweak childNodes to fix test

    mixonic committed Apr 26, 2015
    Copy the full SHA
    a79c586 View commit details
    Browse the repository at this point in the history
  2. Remove unnnecessary test

    mixonic committed Apr 26, 2015
    Copy the full SHA
    4181cc9 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    96895af View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    97fa5ea View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    c278ff5 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    e5d76ee View commit details
    Browse the repository at this point in the history
  7. Update number of observers in test

    It seems that this test was passing in spirit: the number of observers
    does not increase when rerendering.
    mitchlloyd committed Apr 26, 2015
    Copy the full SHA
    f224f28 View commit details
    Browse the repository at this point in the history
  8. Disallow spaces in classNameBindings property

    Interestingly, spaces are allowed when setting classNameBindings on a
    view inside of a template.
    
    {{view classNameBindings="prop:true:false anotherProp:more-true:more-false"}}
    
    However, they are not allowed when setting the property on a view class:
    
    Ember.View.create({
      classNameBindings: 'prop:true:false anotherProp:more-true:more-false'
    });
    
    To handle both of these cases, we split the incoming classNameBindings
    property by spaces when using the view keyword.
    mitchlloyd committed Apr 26, 2015
    Copy the full SHA
    c4cf0ef View commit details
    Browse the repository at this point in the history
  9. Merge pull request #10957 from mitchlloyd/view-attr-fixes

    View attribute fixes
    mixonic committed Apr 26, 2015
    Copy the full SHA
    d739bd0 View commit details
    Browse the repository at this point in the history
  10. Fix layout tests

    mixonic committed Apr 26, 2015
    Copy the full SHA
    8578ade View commit details
    Browse the repository at this point in the history
  11. Update HTMLBars to 0.13.8.

    rwjblue committed Apr 26, 2015
    Copy the full SHA
    210a47c View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    10d0861 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    32d8584 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2015

  1. Copy the full SHA
    af75b40 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ba5f1cf View commit details
    Browse the repository at this point in the history
  3. Merge pull request #10960 from mitchlloyd/tagless-assertion

    Add back assertion for tagless components with classNameBindings
    rwjblue committed Apr 27, 2015
    Copy the full SHA
    f9a192a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2015

  1. Get remainder of query_params_test.js passing

    And a link-to test
    machty committed Apr 28, 2015
    Copy the full SHA
    97c1039 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #10969 from machty/ir-qp

    Get remainder of query_params_test.js passing
    rwjblue committed Apr 28, 2015
    Copy the full SHA
    b162d69 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    af5c3ea View commit details
    Browse the repository at this point in the history
  4. Refactor SubexprStream

    mmun committed Apr 28, 2015
    Copy the full SHA
    82b6968 View commit details
    Browse the repository at this point in the history
  5. Differentiate between mutable and immutable dependencies

    this.addDependency now assumes that the dependee is immutable. In
    particular this means that it no longer returns the Dependency instance.
    If you need access to the dependency you must now call
    this.addMutableDependency.
    
    This change allows this.addDependency to be a no-op if the passed in
    object is not a stream. This is useful for subexpression streams to
    avoid creating unnecessary dependencies for primitive values, as in
    this example:
    
    ```hbs
    {{concat values sep=','}}
    ```
    mmun committed Apr 28, 2015
    Copy the full SHA
    af36378 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    4df3894 View commit details
    Browse the repository at this point in the history
  7. Resolve master merge conflicts

    tilde-engineering authored and tomdale committed Apr 28, 2015
    Copy the full SHA
    d31876a View commit details
    Browse the repository at this point in the history
  8. Merge branch 'idempotent-rerender' of http://github.com/emberjs/ember.js

     into idempotent-rerender
    tilde-engineering authored and tomdale committed Apr 28, 2015
    Copy the full SHA
    a3f96a8 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    afa1199 View commit details
    Browse the repository at this point in the history
  10. publish glimmer builds to bower

    Stanley Stuart committed Apr 28, 2015
    Copy the full SHA
    f74f109 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2015

  1. Copy the full SHA
    967fd42 View commit details
    Browse the repository at this point in the history
  2. Throw when rerender called after rendering

    Just before a block is rendered, views are put into a renderedViews
    list. When `rerender` is called, this list is checked to ensure the view
    being rerendered has not already been rerendered.
    mixonic committed Apr 29, 2015
    Copy the full SHA
    6d43084 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    79c06f1 View commit details
    Browse the repository at this point in the history
  4. Bump htmlbars version

    tomdale committed Apr 29, 2015
    Copy the full SHA
    9d0b5a4 View commit details
    Browse the repository at this point in the history
  5. Unskip some link-to tests

    tomdale committed Apr 29, 2015
    Copy the full SHA
    ab20172 View commit details
    Browse the repository at this point in the history
  6. Add support for intercepting get and set

    These hooks are internal-only, not exposed publicly, and are only
    intended to be used to emulate deprecated functionality for the moment.
    wycats committed Apr 29, 2015
    Copy the full SHA
    f68ceeb View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    60dc11f View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    f0ca068 View commit details
    Browse the repository at this point in the history
  9. Fix preventDefault on link-to

    mmun committed Apr 29, 2015
    Copy the full SHA
    c8dfd40 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    d3ce978 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2015

  1. Copy the full SHA
    8732970 View commit details
    Browse the repository at this point in the history
  2. Bump emberjs-build to 0.1.1

    mmun committed Apr 30, 2015
    Copy the full SHA
    2b5a6dc View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into idempotent-rerender

    Conflicts:
    	packages/ember-views/lib/attr_nodes/legacy_bind.js
    	packages/ember-views/lib/mixins/class_names_support.js
    	packages/ember-views/lib/streams/should_display.js
    	packages/ember-views/lib/views/collection_view.js
    	packages/ember-views/lib/views/core_view.js
    	packages/ember-views/lib/views/select.js
    krisselden committed Apr 30, 2015
    Copy the full SHA
    5e371c0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #10990 from krisselden/idempotent-rerender

    Idempotent rerender
    rwjblue committed Apr 30, 2015
    Copy the full SHA
    6af18a0 View commit details
    Browse the repository at this point in the history
  5. Fix lint errors.

    * `get` was unused in ember-routing-htmlbars/keywords/action
    * Indentation was incorrect in ember-htmlbars/tests/integration/mutable_binding_test
    rwjblue committed Apr 30, 2015
    Copy the full SHA
    53e6eba View commit details
    Browse the repository at this point in the history
  6. Fix incorrect typeOf import.

    `typeOf` moved from `ember-metal/utils` to `ember-runtime/utils` as of
    #10988.
    rwjblue committed Apr 30, 2015
    Copy the full SHA
    a2d9a41 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    ccc13a6 View commit details
    Browse the repository at this point in the history
  8. Refactor controller binding

    tomdale committed Apr 30, 2015
    Copy the full SHA
    b9eb523 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    dc97966 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    85cda2e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2015

  1. Copy the full SHA
    9c9c45c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    cb5f07c View commit details
    Browse the repository at this point in the history
  3. Mostly complete impl of mutable bindings

    There are two failing tests related to timing and I want to investigate
    an alternate approach for mutable cells.
    wycats committed May 1, 2015
    Copy the full SHA
    28f04c6 View commit details
    Browse the repository at this point in the history
  4. Don't leak the stream into user code

    In the previous commit, mutable bindings had a value() method that was a
    live reflection of the underlying stream. Those semantics were
    inconsistent with immutable bindings, which only update during the
    rendering process and trigger lifecycle hooks.
    
    This commit snapshots the value and provides a new mutable cell each
    time through.
    wycats committed May 1, 2015
    Copy the full SHA
    e922169 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    ce28b3c View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    d5fe775 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #10999 from mitchlloyd/fix-create-child-view-tests

    Consistently use `parentView` over `_parentView`
    rwjblue committed May 1, 2015
    Copy the full SHA
    3ba81e3 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #10991 from mitchlloyd/view-computed-controller

    Fix a test for view controller property
    rwjblue committed May 1, 2015
    Copy the full SHA
    5725b5c View commit details
    Browse the repository at this point in the history
  9. Fallback to "-text-field" component name for unrecognized input type

    Previously, using an input type not in the map (such as "email") would
    cause an exception. This renames the `classification` var to more
    expressive `componentNameMap`, and turns the map into a whitelist of
    non-default component names only. Any value of "type" not in that map (or
    no value for "type") will use the default "-text-field" component name.
    bantic committed May 1, 2015
    5
    Copy the full SHA
    5a1c5e1 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #11004 from bantic/idempotent-rerender-fix-input-t…

    …ypes
    
    Fallback to "-text-field" component name for unrecognized input type
    wycats committed May 1, 2015
    Copy the full SHA
    505ec73 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2015

  1. Copy the full SHA
    cd81304 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7f0d4ed View commit details
    Browse the repository at this point in the history
  3. Always set elementId.

    The container view template uses `elementId` as the key for `{{each}}`.
    We need to ensure that even tagless views have an `elementId`.
    rwjblue committed May 2, 2015
    Copy the full SHA
    4507947 View commit details
    Browse the repository at this point in the history
  4. Update remaining skipped View.prototype.createElement.

    * Avoid using `RenderBuffer`
    * assert the output HTML
    rwjblue committed May 2, 2015
    Copy the full SHA
    2b0404b View commit details
    Browse the repository at this point in the history
  5. Prevent clobbering attrs with an attr named attrs.

    When invoking a component like:
    
    ```javascript
    {{foo-bar attrs="blah"}}
    ```
    
    We cannot set `this.attrs` to be equal to `"blah"`.  This is potentially
    breaking for folks that have used `attrs` as a single attribute value in
    the root of a component.
    rwjblue committed May 2, 2015
    Copy the full SHA
    ea44afb View commit details
    Browse the repository at this point in the history
  6. Merge pull request #10958 from mixonic/idempotent-rerender-assert-rer…

    …ender
    
    Throw when rerender called after rendering
    wycats committed May 2, 2015
    Copy the full SHA
    5700eee View commit details
    Browse the repository at this point in the history
  7. Use indexOf from EnumerableUtils.

    It properly defers to the object or polyfil as needed.
    rwjblue committed May 2, 2015
    Copy the full SHA
    9aaa8eb View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    3e66244 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    3493fdc View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    ed43856 View commit details
    Browse the repository at this point in the history
  11. Extract lookupComponent

    tomdale committed May 2, 2015
    Copy the full SHA
    ac680f4 View commit details
    Browse the repository at this point in the history
  12. Make streams aware of proxies

    If a stream value results in a proxy, the stream will begin to observe
    the proxy's content and notify itself if the content changes.
    mmun committed May 2, 2015
    Copy the full SHA
    a4dffa9 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    c340bab View commit details
    Browse the repository at this point in the history
  14. Merge pull request #11008 from krisselden/idempotent-rerender

    Merge master into idempotent rerender
    rwjblue committed May 2, 2015
    Copy the full SHA
    a3d4eba View commit details
    Browse the repository at this point in the history
  15. Style cleanup to fix tests

    mixonic committed May 2, 2015
    Copy the full SHA
    8e82692 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2015

  1. Copy the full SHA
    4e585da View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    18bf2f3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c0df0cd View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    b12adfb View commit details
    Browse the repository at this point in the history
  5. Adds a way to reliably read from DOM

    The readDOMAttr method on views makes it possible to read an attribute
    from DOM and update the internal lastValue at the same time.
    
    This effectively fixes the fact that some attribute sets are not
    idempotent, which causes problems for the write-only pure-function
    rendering model used by Glimmer and React.
    wycats committed May 3, 2015
    Copy the full SHA
    918f69d View commit details
    Browse the repository at this point in the history
  6. Use readDOMAttr + attributeBinding for <textarea>.

    The new `readDOMAttr` API allows us to remove this manual `value`
    property binding in `Ember.TextArea`.
    rwjblue committed May 3, 2015
    Copy the full SHA
    a805745 View commit details
    Browse the repository at this point in the history
  7. Update HTMLBars to v0.13.11.

    * Remove 'value' attribute hacks.
    * Add `AttrMorph.prototype.getContent`.
    rwjblue committed May 3, 2015
    Copy the full SHA
    0e674a4 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    2d501df View commit details
    Browse the repository at this point in the history
  9. Merge pull request #10977 from fivetanley/bower-idemptotent-rerender

    publish idemptotent rerender to bower
    rwjblue committed May 3, 2015
    Copy the full SHA
    c762400 View commit details
    Browse the repository at this point in the history
  10. Fix dynamic makeViewHelper.

    rwjblue committed May 3, 2015
    Copy the full SHA
    57f05da View commit details
    Browse the repository at this point in the history
  11. Fix dynamic makeViewHelper.

    rwjblue committed May 3, 2015
    Copy the full SHA
    73881e4 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    4189eb0 View commit details
    Browse the repository at this point in the history
  13. Fix stream teardown... I think

    mmun committed May 3, 2015
    Copy the full SHA
    d1da840 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    de821af View commit details
    Browse the repository at this point in the history
  15. Merge pull request #11012 from mixonic/idempotent-rerender-buffer

    Bring back the render hook with a pushable buffer
    mixonic committed May 3, 2015
    Copy the full SHA
    86ecba9 View commit details
    Browse the repository at this point in the history
  16. Copy the full SHA
    5a33e9c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2015

  1. Copy the full SHA
    658f260 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    42b5df0 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4f46a23 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    4cfb2bd View commit details
    Browse the repository at this point in the history
  5. Make JSCS happy.

    rwjblue committed May 4, 2015
    Copy the full SHA
    6795e0b View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    5d38b79 View commit details
    Browse the repository at this point in the history
  7. Fix propagation test.

    rwjblue committed May 4, 2015
    Copy the full SHA
    a4f9da4 View commit details
    Browse the repository at this point in the history
  8. Remove deprecation on accessing attrs in component root.

    We have not fully fleshed out the transition plan for this. Remove the
    deprecation until we have...
    rwjblue committed May 4, 2015
    Copy the full SHA
    b010313 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    0672868 View commit details
    Browse the repository at this point in the history
  10. Don't warn when for-compat stream is not a path

    The `(mut foo)` construction is designed to throw an error if you try to
    do `(mut "foo")`, for obvious reasons.
    
    When I wrote that error, I missed an alternative scenario:
    
    ```hbs
    {{!-- component-one: --}}
    
    {{!-- bar is not a path here --}}
    <component-two foo="bat" />
    
    {{!-- component-two: --}}
    
    {{!-- attrs.foo is a path here --}}
    <component-three baz={{mut attrs.foo}} />
    ```
    
    In this case, `attrs.foo` is a path, but it directly refers to a string,
    which is itself not mutable.
    
    With angle-bracket components, when `{{mut}}` is explicit, the error
    still makes sense: `<component-three>` should not try to mutate
    `attrs.foo` and we should warn as soon as we can.
    
    Unfortunately, that logic does not apply to the compatibility work we
    are doing:
    
    ```hbs
    {{!-- component-one: --}}
    
    {{component-two foo="bat"}}
    
    {{!-- component-two: --}}
    
    {{component-three baz=attrs.foo}}
    ```
    
    In this case, we can't know ahead of time that `attrs.foo` refers to a
    non-mutator, so we have to allow for the possibility that this is a
    two-way binding. For what it's worth, scenarios like this, which are
    clearly bugs (`component-three` settting `baz`), help to explain the
    motivation for the change in the first place.
    
    This commit adds a private `@mut` that can support the looser semantics
    of Ember 1.x curly components, while retaining the stricter errors for
    explicit calls to `mut` used with angle bracket components.
    wycats committed May 4, 2015
    Copy the full SHA
    807a0cd View commit details
    Browse the repository at this point in the history
  11. Intercept property changes instead of sets

    (cherry picked from commit b4d53bfd2d2769c4133f5f55e5551c6cc2dc87f8)
    mmun authored and rwjblue committed May 4, 2015
    Copy the full SHA
    27a6c57 View commit details
    Browse the repository at this point in the history
  12. Unskip mutable binding test.

    rwjblue committed May 4, 2015
    Copy the full SHA
    d9e5c80 View commit details
    Browse the repository at this point in the history
  13. Publish Glimmer builds to S3.

    Make testing apps easier...
    rwjblue committed May 4, 2015
    Copy the full SHA
    a233059 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    12b2496 View commit details
    Browse the repository at this point in the history
  15. Bring Ember._Metamorph and Ember._MetamorphView back and deprecate.

    ember-test-helpers still attempts to register `Ember._Metamorph` as
    `view:default` which causes an error. We will need to update
    ember-test-helpers to check for its existence first and remove the
    globals at a later date.
    rwjblue committed May 4, 2015
    Copy the full SHA
    dddca9a View commit details
    Browse the repository at this point in the history
  16. Revert "Allow publishing of idempotent-rerender PR to S3."

    This reverts commit 12b2496.
    
    This was accidentally pushing the glimmer builds to `canary` URL's.
    
    Removed for now.  Lets just merge this PR....
    rwjblue committed May 4, 2015
    Copy the full SHA
    ff82f2e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2015

  1. outlet keywords must pass the template to render as template

    Previously, they were passing it as layout which smashed a layout that
    may have existed on the view being rendered.
    mixonic committed May 5, 2015
    Copy the full SHA
    f81b17d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #11022 from mixonic/idempotent-rerender-layout

    outlet keywords must pass the template to render as template
    rwjblue committed May 5, 2015
    Copy the full SHA
    5bbfe68 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    535e44b View commit details
    Browse the repository at this point in the history
  4. Remove dead code

    mmun committed May 5, 2015
    Copy the full SHA
    4d177ca View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    12cd907 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    820d559 View commit details
    Browse the repository at this point in the history
  7. Add test controller propagation from route driven views.

    (cherry picked from commit 035545ed2c47b84f1c104d3e22bded6f72db1a37)
    rwjblue committed May 5, 2015
    Copy the full SHA
    38a9d86 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    691a5b0 View commit details
    Browse the repository at this point in the history