Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Ensure 'use strict'; remover comments are not stripped. #10604

Merged
merged 1 commit into from Mar 11, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 11, 2015

Somewhere throughout our build pipeline, leading comments are being stripped. This meant that the REMOVE_USE_STRICT comments could not be found, and the modules were still in strict mode when they should not have been.

@rwjblue rwjblue mentioned this pull request Mar 11, 2015
@stefanpenner
Copy link
Member

Nice. This is likely a better solution.

@rwjblue I won't if the recent babel stuff was the reason?

@rwjblue
Copy link
Member Author

rwjblue commented Mar 11, 2015

Yes, either the switch to Esperanto or adding babel caused this. In general comments aren't handed quite right, and these comments were being completely stripped from the build output. I didn't take too much time trying to figure out which of the tools was the culprit though.

@stefanpenner
Copy link
Member

LGTM

stefanpenner added a commit that referenced this pull request Mar 11, 2015
[BUGFIX beta] Ensure 'use strict'; remover comments are not stripped.
@stefanpenner stefanpenner merged commit a6fdd05 into emberjs:master Mar 11, 2015
@stefanpenner stefanpenner deleted the fix-funky-commment-stripping branch March 11, 2015 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants