[BUGFIX release] Correctly update URL after browser popstate #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mutewinter @rwjblue Is there anything special I need to do with prefixing the commit? |
This commit partially reverts 7afdc41, which introduced a regression in the way HistoryLocation works. Prior to the above-mentioned commit, we would always consult the browser’s state stack when determining what the current path was. The one exception to this was in cases where HistoryLocation was used in browsers that do not support the history API. In that case, the in line comments described a fallback “polyfill” for tracking state. Our rationale behind the refactor was that, if we have a fallback path anyway, we should just always use that instead of having two paths through the system. In reality, the fallback path was a lower-fidelity implementation. In particular, there was no analog to the user hitting the back button, which generates a popstate event. This commit reverts to the old behavior, so if the browser supports history state, we always check its current state when setting the URL. This makes sure that the path is correctly determined even if the user hit the back button, rather than using the last cached set value. Fixes #10801
rwjblue
force-pushed
the
fix-router-regression
branch
from
759800a
to
11b32a9
Compare
rwjblue
changed the title
|
Rebased and updated commit prefix to |
rwjblue
added a commit
that referenced
this pull request
Apr 2, 2015
[BUGFIX release] Correctly update URL after browser popstate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts 7afdc41, which introduced a regression in the way HistoryLocation works.
Prior to the above-mentioned commit, we would always consult the browser’s state stack when determining what the current path was.
The one exception to this was in cases where HistoryLocation was used in browsers that do not support the history API. In that case, the in line comments described a fallback “polyfill” for tracking state.
Our rationale behind the refactor was that, if we have a fallback path anyway, we should just always use that instead of having two paths through the system.
In reality, the fallback path was a lower-fidelity implementation. In particular, there was no handling of the user hitting the back button, which generates a
popstateevent.This commit reverts to the old behavior, so if the browser supports history state, we always check its current state when setting the URL. This makes sure that the path is correctly determined even if the user hit the back button, rather than using the last cached set value.
Fixes #10801.