[BUGFIX] Namespaced strings conversions

[artych]

Fixes #11000

[fivetanley]

It's not immediately obvious when I read the code what STRING_CAMELIZE_REGEXP_2 is for. The change itself LGTM but it'd be great for future visits to the code to have something more intention revealing. Reading RegExp's is hard and it's not clear why _2 and not _2 exist

[artych]

Thank you, @fivetanley. I will clean up code, but I'd like to understand you correctly. There were at least 3 options of coding in that file before this PR:
Option 1 (2 regexp vars):

var STRING_UNDERSCORE_REGEXP_1 = (/([a-z\d])([A-Z]+)/g);
var STRING_UNDERSCORE_REGEXP_2 = (/\-|\s+/g);
var UNDERSCORE_CACHE = new Cache(1000, function(str) {
  return str.replace(STRING_UNDERSCORE_REGEXP_1, '$1_$2').
    replace(STRING_UNDERSCORE_REGEXP_2, '_').toLowerCase();
});

Option 2 (1 regexp var, 1 inline regexp):

var CAMELIZE_CACHE = new Cache(1000, function(key) {
  return key.replace(STRING_CAMELIZE_REGEXP, function(match, separator, chr) {
    return chr ? chr.toUpperCase() : '';
  }).replace(/^([A-Z])/, function(match, separator, chr) {
    return match.toLowerCase();
  });
});

Option 3 (without regexp):

var CLASSIFY_CACHE = new Cache(1000, function(str) {
  var parts = str.split(".");
  var out = [];

  for (var i=0, l=parts.length; i<l; i++) {
    var camelized = camelize(parts[i]);
    out.push(camelized.charAt(0).toUpperCase() + camelized.substr(1));
  }

  return out.join(".");
});

Quite a diverse mix, isn't it? Which option do you suggest me to follow to make this PR code immediately obvious?

[artych]

Since no response, I've clean the code in favor of option 1, moved regexp vars just before function they used in, added comments. IMHO it looks better now.

[fivetanley]

LGTM. Can you amend the commit message to be [BUGFIX beta] so it goes out this release?

@stefanpenner r?

[artych]

@fivetanley [BUGFIX beta] done.

[artych]

Looks like forgotten during major changes?

[rwjblue]

Yeah, sorry about that.