[BUGFIX beta] Ensure parentView includes yielding component.
#11266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! It unblocks a large amount of glimmer testing |
|
|
||
| registry.register('component:x-outer', Component.extend({ | ||
| init() { | ||
| this._super(...arguments); |
There was a problem hiding this comment.
Fun fact: This transpiles directly to:
this._super.apply(this, arguments);
Which is awesome. Elsewhere in ember we use (and I am far less crazy about):
registry.register('component:x-outer', Component.extend({
init(...args) {
this._super(...args);
outer = this;
}
}));
Which builds an intermediate array of args before unrolling.
rwjblue
added a commit
that referenced
this pull request
May 25, 2015
[BUGFIX beta] Ensure `parentView` includes yielding component.
|
when can we see this in canary/beta channel? |
|
Should already be available from bower for both beta and canary channels. |
|
Did this get reverted before 2.0.0-beta.1? I can't seem to find this change, and I think I'm seeing this causing an error in adopted-ember-addons/emberx-select#44 in this code https://github.com/thefrontside/emberx-select/blob/54f9aee9e9b53c586623646a7f8966ce26321736/addon/components/x-option.js#L58 |
cowboyd
added a commit
to adopted-ember-addons/emberx-select
that referenced
this pull request
Jul 20, 2015
In order to fetch the parentView for an element reliably, we depend on a bugfix that only came available in Ember v1.13.4 emberjs/ember.js#11266 This also adds a test case that was breaking in 1.13.{0-3} resolves #44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11170.