Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Link to attribute bindings #11594

Merged
merged 1 commit into from
Jun 29, 2015
Merged

[BUGFIX] Link to attribute bindings #11594

merged 1 commit into from
Jun 29, 2015

Conversation

mike-north
Copy link
Contributor

Fixes #11593

This is a 1.13.x PR, being pulled into the stable branch

Currently, addons and apps that have code like this

  Ember.LinkView.reopen({
    attributeBindings: ['data-activates']
  });

may be breaking in 1.13. This is due to the fact that {{link-to}} maps to LinkComponent instead of LinkView.

This PR ensures that the above pattern works throughout the ember 1.x releases.

@rwjblue
Copy link
Member

rwjblue commented Jun 29, 2015

Unless Ember.LinkView has already been removed in canary/beta this PR should go there (to fix those channels as well until we remove the global Ember.LinkView).

@rwjblue
Copy link
Member

rwjblue commented Jun 29, 2015

Can you also grep for Ember.LinkView in the code base to make sure the API docs suggest the right thing going forward?

@stefanpenner
Copy link
Member

Unless Ember.LinkView has already been removed in canary/beta this PR should go there (to fix those channels as well until we remove the global Ember.LinkView).

It is removed from canary but it appears beta may need it. It seems strange to PR to canary, would you prefer a PR to beta ? or...

@rwjblue
Copy link
Member

rwjblue commented Jun 29, 2015

@stefanpenner - Thanks for confirming, this is good to go against stable branch then. Sorry for the noise, y'all.

rwjblue added a commit that referenced this pull request Jun 29, 2015
@rwjblue rwjblue merged commit 777a00d into emberjs:stable Jun 29, 2015
mike-north added a commit to mike-north/guides that referenced this pull request Jul 2, 2015
michaelrkn pushed a commit to emberjs/guides that referenced this pull request Jul 28, 2015
locks pushed a commit to emberjs/guides that referenced this pull request Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants