Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove deprecated {{each foo as bar}} AST transform #11776

Merged
merged 1 commit into from Jul 16, 2015
Merged

[CLEANUP beta] Remove deprecated {{each foo as bar}} AST transform #11776

merged 1 commit into from Jul 16, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2015

Resolves #11772

The following test fails:
https://github.com/emberjs/ember.js/blob/master/packages/ember-htmlbars/tests/helpers/each_test.js#L451

I tried changing the each in to each as but no luck.
I'll probably keep on removing deprecated stuff until this test goes away

@rwjblue
Copy link
Member

rwjblue commented Jul 16, 2015

Yeah, you can't use block params without a block. You can remove this and change this to {{#each view.people itemViewClass="foo-view" as |person|}}{{person.name}}{{/each}}.

If that doesn't work, delete the test (it is using deprecated itemViewClass anyways).

@ghost
Copy link
Author

ghost commented Jul 16, 2015

I removed the test as the suggested change triggered that it couldn't find itemViewClass foo-view.

@rwjblue
Copy link
Member

rwjblue commented Jul 16, 2015

👍

@stefanpenner
Copy link
Member

kicking the 1 failed test scenario

@ghost
Copy link
Author

ghost commented Jul 16, 2015

Fix'd

mmun added a commit that referenced this pull request Jul 16, 2015
[CLEANUP beta] Remove deprecated `{{each foo as bar}}` AST transform
@mmun mmun merged commit 96e08c3 into emberjs:master Jul 16, 2015
@mmun mmun deleted the remove-each-as-transform branch July 16, 2015 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants