Ensure attributeBindings work when legacy view addon is disabled. #12318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the stream implementation in great detail and didn't catch that this is what was resulting in the attributes not being present. We've seen similar behavior from liquid-fire–I'll confirm that this is a "likely-complete" fix tomorrow. |
When the `_Ember.ENV._LEGACY_VIEW_SUPPORT` flag is falsey, the `view` stream is not setup as of 6963750. This resulted in anything added in `attributeBindings` being `undefined` (because the attribute binding system was essentially using `href=view.href` instead of `href=this.href` or just `href=href`). You might thing (as I did initially): "HOW CAN WE NOT HAVE A SINGLE TEST THAT CHECKS FOR AN ATTRIBUTE VALUE?!?!?!?", and the answer is somewhat more disconcerting. We currently run all tests with the legacy view and controller flags set to `true`. :( Future test refactoring efforts will be needed to fix that mistake.
rwjblue
force-pushed
the
fix-attribute-bindings
branch
from
30439cf
to
b60e201
Compare
|
Updated to avoid using a path at all when it is not needed ( |
rwjblue
added a commit
that referenced
this pull request
Sep 10, 2015
Ensure attributeBindings work when legacy view addon is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
_Ember.ENV._LEGACY_VIEW_SUPPORTflag is falsey, theviewstream is not setup as of 6963750. This resulted in anything added inattributeBindingsbeingundefined(because the attribute binding system was essentially usinghref=view.hrefinstead ofhref=this.hrefor justhref=href).You might thing (as I did initially): "HOW CAN WE NOT HAVE A SINGLE TEST THAT CHECKS FOR AN ATTRIBUTE VALUE?!?!?!?", and the answer is somewhat more disconcerting. We currently run all tests with the legacy view and controller flags set to
true. :(Future test refactoring efforts will be needed to fix that mistake.
Fixes #12302.