WIP: rootURL -> rootPath #12338
Closed
WIP: rootURL -> rootPath #12338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesarosen
force-pushed
the
location-base-url
branch
2 times, most recently
from
f65571a
to
db91982
Compare
| @@ -27,7 +29,7 @@ export default EmberObject.extend({ | |||
|
|
|||
| init() { | |||
| set(this, 'location', get(this, 'location') || window.location); | |||
| set(this, 'baseURL', jQuery('base').attr('href') || ''); | |||
| set(this, 'baseURL', jQuery('base').prop('href') || ''); | |||
There was a problem hiding this comment.
This is an important change. baseURL will always be a URL now.
jamesarosen
force-pushed
the
location-base-url
branch
from
db91982
to
c034e85
Compare
jamesarosen
force-pushed
the
location-base-url
branch
from
c034e85
to
5be19d2
Compare
|
Closing as this seems to have gone stale, I'm happy to reopen if you would like to pick this back up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to address #5334