Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ember-registry-container-reform feature flag. #12441

Merged
merged 1 commit into from Oct 5, 2015

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Oct 5, 2015

This flag is no longer needed now that this feature is out of beta.

This flag is no longer needed now that this feature is out of beta.
@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2015

Thanks for cleaning this up!


Can you confirm that the appInstance.container.lookup and appInstance.registry.* deprecations are still under test (with expectDeprecation)? I just want to make sure there is a test that will fail if we break those (since they should be left in until 3.0.0).

@dgeb
Copy link
Member Author

dgeb commented Oct 5, 2015

@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2015

Awesome, thank you for confirming!

rwjblue added a commit that referenced this pull request Oct 5, 2015
Remove `ember-registry-container-reform` feature flag.
@rwjblue rwjblue merged commit 23258c1 into emberjs:master Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants