[BUGFIX canary] Create new hash when merging parameters hashes in components #12542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, this is still canary. |
Serabe
changed the title
|
Would love to see this merged and in canary.. |
|
👍 Confirmed that this fixes the issue in our app. Thanks, @Serabe ! |
|
@Serabe is correct, this feature is only in canary so no channel back porting needed. |
| export function mergeHash(original, updates) { | ||
| return assign(original, updates); | ||
| export function mergeInNewHash(original, updates) { | ||
| return assign(Object.create(original), updates); |
There was a problem hiding this comment.
Do we need object inheritance here? Would the following also work:
assign({}, original, updates);
…ponents When merging two parameters hashes coming from components/closure components we want them to be merged into a new hash. This refactors does not only make this happen but it changes `mergeHash` into `mergeInNewHah` to be explicit about this. Fix emberjs#12537
|
@rwjblue fixed. @stefanpenner comment was because I forgot to tag it, not because of canary/beta. |
|
Ahh, gotcha. Thanks for updating the prefix. |
|
Looks good to me, I restarted the sauce labs job. |
rwjblue
added a commit
that referenced
this pull request
Nov 1, 2015
[BUGFIX canary] Create new hash when merging parameters hashes in components
|
Thanks for jumping on this so quickly @Serabe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging two parameters hashes coming from components/closure components we
want them to be merged into a new hash. This refactors does not only make this
happen but it changes
mergeHashintomergeInNewHahto be explicit aboutthis.
Fix #12537